Tarantool development patches archive
 help / color / mirror / Atom feed
* [PATCH v2 0/2] fix bodiless requests handling.
@ 2018-09-24 14:08 Serge Petrenko
  2018-09-24 14:08 ` [PATCH v2 1/2] tarantoolctl: fix cat and play for empty body requests Serge Petrenko
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Serge Petrenko @ 2018-09-24 14:08 UTC (permalink / raw)
  To: vdavydov.dev; +Cc: tarantool-patches, Serge Petrenko

The first patch fixes an error when trying to parse a bodiless request
such as IPROTO_NOP in `tarantoolctl cat` and `tarantoolctl play`.
Now cat displays such requests correctly and play ignores them.
https://github.com/tarantool/tarantool/issues/3675

The second patch fixes parsing xlogs containing transactions with
empty body requests. Such requests weren't handled correctly which lead to
header of the next request become body of a no-op request. This messed up recovery
and `tarantoolctl cat`. Both fixed.
https://github.com/tarantool/tarantool/issues/3678

Branch:
https://github.com/tarantool/tarantool/tree/sp/gh-3675-tarantoolctl-cat-empty-body

Changes in v2:
  - make sure that tarantoolctl cat and play
    stops on all records with lsn >= to, even
    the ones that have to be skipped.
  - move NOP recovery test to box/before_replace.test.lua
  - decided to ignore old xlogs with NOPS with body.
  - simplify check for NOP in xrow_header_decode()


Serge Petrenko (2):
  tarantoolctl: fix cat and play for empty body requests
  recovery: fix incorrect handling of empty-body requests.

 extra/dist/tarantoolctl.in         | 32 ++++++++++++++++++------------
 src/box/xrow.c                     |  3 ++-
 test/app-tap/tarantoolctl.test.lua | 14 ++++++++++---
 test/box/before_replace.result     | 25 ++++++++++++++++++++---
 test/box/before_replace.test.lua   | 14 ++++++++++---
 5 files changed, 65 insertions(+), 23 deletions(-)

-- 
2.17.1 (Apple Git-112)

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-25 22:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-24 14:08 [PATCH v2 0/2] fix bodiless requests handling Serge Petrenko
2018-09-24 14:08 ` [PATCH v2 1/2] tarantoolctl: fix cat and play for empty body requests Serge Petrenko
2018-09-25 22:31   ` [tarantool-patches] " Konstantin Osipov
2018-09-24 14:08 ` [PATCH v2 2/2] recovery: fix incorrect handling of empty-body requests Serge Petrenko
2018-09-25 22:33   ` [tarantool-patches] " Konstantin Osipov
2018-09-25 14:37 ` [PATCH v2 0/2] fix bodiless requests handling Vladimir Davydov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox