From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v3.1 2/5] box: introduce tuple_field_by_part routine
Date: Fri, 21 Sep 2018 12:33:14 +0300 [thread overview]
Message-ID: <20180921093314.amihvfr3p4lmguiq@esperanza> (raw)
In-Reply-To: <dfd140a07eada6a426346026e68aaa7cd77d5ace.1537429335.git.kshcherbatov@tarantool.org>
On Thu, Sep 20, 2018 at 10:46:50AM +0300, Kirill Shcherbatov wrote:
> +const char *
> +tuple_field_by_part_raw(const struct tuple_format *format, const char *data,
> + const uint32_t *field_map, struct key_part *part)
> +{
> + return tuple_field_raw(format, data, field_map, part->fieldno);
> +}
This function must be defined as inline for now so as not to introduce
any slowdown to hot paths. I moved it to tuple_format.h and pushed the
patch to 1.10. You'll have to move it back to tuple_format.c in the main
patch of the series, which makes it more than just a wrapper.
next prev parent reply other threads:[~2018-09-21 9:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 7:46 [PATCH v3.1 0/5] box: indexes by JSON path Kirill Shcherbatov
2018-09-20 7:46 ` [PATCH v3.1 1/5] box: refactor API to use non-constant key_def Kirill Shcherbatov
2018-09-21 9:30 ` Vladimir Davydov
2018-09-20 7:46 ` [PATCH v3.1 2/5] box: introduce tuple_field_by_part routine Kirill Shcherbatov
2018-09-21 9:33 ` Vladimir Davydov [this message]
2018-09-20 7:46 ` [PATCH v3.1 3/5] box: introduce JSON indexes Kirill Shcherbatov
2018-09-22 19:15 ` Vladimir Davydov
2018-09-20 7:46 ` [PATCH v3.1 4/5] box: introduce offset slot cache in key_part Kirill Shcherbatov
2018-09-20 7:46 ` [PATCH v3.1 5/5] box: specify indexes in user-friendly form Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921093314.amihvfr3p4lmguiq@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v3.1 2/5] box: introduce tuple_field_by_part routine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox