Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: roman.habibov1@yandex.ru
Cc: tarantool-patches@freelists.org,
	Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature
Date: Fri, 21 Sep 2018 05:53:47 +0300	[thread overview]
Message-ID: <20180921025347.ommfgqpn7v35vi6p@tkn_work_nb> (raw)
In-Reply-To: <5087171537491282@myt5-f9d71769b752.qloud-c.yandex.net>

Hi!

Minor comments are below.

WBR, Alexander Turenko.

On Fri, Sep 21, 2018 at 03:54:42AM +0300, roman.habibov1@yandex.ru wrote:
> 
> Add output filtering feature for engine/savepoint.test.
> 
> Part of #3518.
> ---
> commit b8be4c51e29110f459bd58dba51d6546cd9da25b
> Author: Roman Khabibov <roman.habibov1@yandex.ru>
> Date:   Fri Sep 21 03:28:04 2018 +0300
> 
>     test: add output filtering feature
> 

Please, describe the change in less abstract manner, like 'test: filter
line numbers from engine/savepoint'. Now the description looks like you
are implement this feature from scratch.

> diff --git a/test/engine/savepoint.test.lua b/test/engine/savepoint.test.lua
> index de8f297..9d4be7f 100644
> --- a/test/engine/savepoint.test.lua
> +++ b/test/engine/savepoint.test.lua
> @@ -1,5 +1,6 @@
>  env = require('test_run')
>  test_run = env.new()
> +test_run:cmd("push filter '(.builtin/.*).lua:346' to '\\1.lua:340'")
>  

Tricky thing :)

It is better to remove line numbers entirely as socket.test.lua does and
update the result file, because the current approach does not protect us
from the next line numbers change.

Also I propose to place this commit before 'box: add a method to check
if txn is open' to achieve two points:

* each commit passes the tests (can be useful when someone will bisect
  some problem in the future and is generally recommended way);
* don't need to update the test result twice (update line numbers, then
  remove line numbers).

  reply	other threads:[~2018-09-21  2:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07  1:00 [tarantool-patches] [PATCH] box: add a method to check if transaction is open Roman Khabibov
2018-09-10  6:21 ` [tarantool-patches] " Kirill Shcherbatov
2018-09-11  0:23   ` roman.habibov1
2018-09-11  0:25     ` roman.habibov1
2018-09-11 11:51       ` Kirill Shcherbatov
2018-09-19 13:38         ` Alexander Turenko
2018-09-21  0:54           ` [tarantool-patches] Re: [PATCH 1/1] " roman.habibov1
2018-09-21  2:41             ` Alexander Turenko
2018-09-21 22:29               ` roman.habibov1
2018-09-22  1:00                 ` Alexander Turenko
2018-09-23 10:11                   ` Vladislav Shpilevoy
2018-09-21  0:54           ` [tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature roman.habibov1
2018-09-21  2:53             ` Alexander Turenko [this message]
2018-09-21 22:25               ` roman.habibov1
2018-09-24  8:38 ` [tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921025347.ommfgqpn7v35vi6p@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=roman.habibov1@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox