Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: roman.habibov1@yandex.ru
Cc: "tarantool-patches@freelists.org"
	<tarantool-patches@freelists.org>,
	Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/1] box: add a method to check if transaction is open
Date: Fri, 21 Sep 2018 05:41:45 +0300	[thread overview]
Message-ID: <20180921024144.5x5vu3qrdcdoa24v@tkn_work_nb> (raw)
In-Reply-To: <5119501537491277@myt3-12f13c3c6b95.qloud-c.yandex.net>

This commit looks good to me, except one comment.

WBR, Alexander Turenko.

> +box.is_in_txn = function()
> +    return builtin.box_txn()
> +end
> +

Can be reduced to just `box.is_in_txn = builtin.box_txn`.

  reply	other threads:[~2018-09-21  2:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07  1:00 [tarantool-patches] [PATCH] " Roman Khabibov
2018-09-10  6:21 ` [tarantool-patches] " Kirill Shcherbatov
2018-09-11  0:23   ` roman.habibov1
2018-09-11  0:25     ` roman.habibov1
2018-09-11 11:51       ` Kirill Shcherbatov
2018-09-19 13:38         ` Alexander Turenko
2018-09-21  0:54           ` [tarantool-patches] Re: [PATCH 1/1] " roman.habibov1
2018-09-21  2:41             ` Alexander Turenko [this message]
2018-09-21 22:29               ` roman.habibov1
2018-09-22  1:00                 ` Alexander Turenko
2018-09-23 10:11                   ` Vladislav Shpilevoy
2018-09-21  0:54           ` [tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature roman.habibov1
2018-09-21  2:53             ` Alexander Turenko
2018-09-21 22:25               ` roman.habibov1
2018-09-24  8:38 ` [tarantool-patches] Re: [PATCH] box: add a method to check if transaction is open Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921024144.5x5vu3qrdcdoa24v@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=roman.habibov1@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 1/1] box: add a method to check if transaction is open' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox