From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: decrease SELECT_COMPOUND_LIMIT threshold
Date: Thu, 20 Sep 2018 18:58:16 +0300 [thread overview]
Message-ID: <20180920155816.hxbjevxjhio43fnr@tarantool.org> (raw)
In-Reply-To: <d67026a5945783bd669e393ea0a839ce9b35983c.1536666375.git.kshcherbatov@tarantool.org>
Hello,
On 11 сен 14:47, Kirill Shcherbatov wrote:
> Decreased the maximum number of terms in a compound SELECT
> statement. The code generator for compound SELECT statements
> does one level of recursion for each term. A stack overflow can
> result if the number of terms is too large. In practice, most
> SQL never has more than 3 or 4 terms.
> Fiber stack is 64KB by default, so maximum number of entities
> should be about 30 to stack guard will not be triggered.
>
> Closes #3382.
> ---
> Branch: http://github.com/tarantool/tarantool/tree/kshsh/gh-3382-select-compound-limit-fix
> Issue: https://github.com/tarantool/tarantool/issues/3382
I've checked your patch into 2.0 branch.
BTW, I've submitted feature request to relax the restriction:
https://github.com/tarantool/tarantool/issues/3700
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2018-09-20 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 11:47 [tarantool-patches] " Kirill Shcherbatov
2018-09-11 21:33 ` [tarantool-patches] " n.pettik
2018-09-13 8:42 ` Kirill Shcherbatov
2018-09-19 21:29 ` n.pettik
2018-09-20 8:32 ` Kirill Shcherbatov
2018-09-20 8:49 ` n.pettik
2018-09-20 15:58 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920155816.hxbjevxjhio43fnr@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: decrease SELECT_COMPOUND_LIMIT threshold' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox