[tarantool-patches] Re: [PATCH] Fix Debug build on GCC 8

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,
On 15 сен 09:07, Alexander Turenko wrote:
> Fixed false positive -Wimplicit-fallthrough in http_parser.c by adding a
> break. The code jumps anyway, so the execution flow is not changed.
> 
> Fixed false positive -Wparenthesis in reflection.h by removing the
> parentheses. The argument 'method' of the macro 'type_foreach_method' is
> just name of the loop variable and is passed to the macro for
> readability reasons.
> 
> Fixed false positive -Wcast-function-type triggered by reflection.h by
> adding -Wno-cast-function-type for sources and unit tests. We cast a
> pointer to a member function to an another pointer to member function to
> store it in a structure, but we cast it back before made a call. It is
> legal and does not lead to an undefined behaviour.
> 
> Fixes #3685.
> ---
> 
> issue: https://github.com/tarantool/tarantool/issues/3685
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-3685-fix-debug-build-gcc-8
> travis-ci: https://travis-ci.org/tarantool/tarantool/builds/428903995
I've checked the patch into 1.9 branch.

--
Regards, Kirill Yukhin