[tarantool-patches] Re: [PATCH v2] test: enable parallel mode for wall_off tests

[Alexander Turenko <alexander.turenko@tarantool.org>]

Hi!

Comments are below.

WBR, Alexander Turenko.

Maybe we should place the fix on top of 1.9. I asked Kostya O. and
Kirill Yu. about that in the chat, please ping them and proceed
appropriately.

> enable parallel mode for wall_off tests

wall -> wal

> diff --git a/test/wal_off/lua.test.lua b/test/wal_off/lua.test.lua
> index 7daf9f3f6..02ec9e795 100644
> --- a/test/wal_off/lua.test.lua
> +++ b/test/wal_off/lua.test.lua
> @@ -1,5 +1,6 @@
>  env = require('test_run')
>  test_run = env.new()
> +test_run:cmd("restart server default with cleanup=1")

So the approach is to restart the server with clean up for each tests.
It will slows down the execution. The another way you propose (w/ spaces
renaming) seems to be better for me.

Anyway, you don't describe a reason why exactly this is needed. How we
can meet an inconsistent state if a server was not restarted or
restarted with clean up? I propose to describe problems you fix in the
commit message, otherwise I'll need to investigate the issue again after
you to understand it and give the review.