From: Alexander Turenko <alexander.turenko@tarantool.org> To: Sergei Voronezhskii <sergw@tarantool.org> Cc: tarantool-patches@freelists.org, Vladimir Davydov <vdavydov.dev@gmail.com> Subject: Re: [tarantool-patches] [PATCH] test: skip ddl test for vinyl on travis Date: Mon, 17 Sep 2018 21:11:19 +0300 [thread overview] Message-ID: <20180917181119.tbsjrn7ngwd7bmk6@tkn_work_nb> (raw) In-Reply-To: <20180917174202.12907-1-sergw@tarantool.org> Hi! See comments below. WBR, Alexander Turenko. On Mon, Sep 17, 2018 at 08:42:02PM +0300, Sergei Voronezhskii wrote: > Until the bug in #3420 is fixed > --- > branch: sergw/travis-skip-test-ddl > .travis.mk | 1 + > rpm/tarantool.spec | 2 ++ > test/vinyl/ddl.skipcond | 6 ++++++ > 3 files changed, 9 insertions(+) > create mode 100644 test/vinyl/ddl.skipcond > > diff --git a/.travis.mk b/.travis.mk > index 23f804cde..795493855 100644 > --- a/.travis.mk > +++ b/.travis.mk > @@ -26,6 +26,7 @@ docker_%: > -e XDG_CACHE_HOME=/cache \ > -e CCACHE_DIR=/cache/ccache \ > -e COVERALLS_TOKEN=${COVERALLS_TOKEN} \ > + -e TRAVIS=${TRAVIS} \ > -e TRAVIS_JOB_ID=${TRAVIS_JOB_ID} \ We can just use TRAVIS_JOB_ID, are we don't? I think we should not overuse environment customization facilities and even avoid it where possible. > ${DOCKER_IMAGE} \ > make -f .travis.mk $(subst docker_,,$@) > diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec > index c87b1667d..bd2469d90 100644 > --- a/rpm/tarantool.spec > +++ b/rpm/tarantool.spec > @@ -149,6 +149,8 @@ rm -rf %{buildroot}%{_datarootdir}/doc/tarantool/ > echo "self.skip = True" > ./test/app/socket.skipcond > # https://github.com/tarantool/tarantool/issues/1322 > echo "self.skip = True" > ./test/app/digest.skipcond > +# https://github.com/tarantool/tarantool/issues/3420 > +echo "self.skip = True" > ./test/vinyl/ddl.skipcond Ok. It should not be part of this patch, but can you elaborate whether we can remove two skipconds above? Maybe it worth to file a separate issue for that. > # run a safe subset of the test suite > cd test && ./test-run.py -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/ > %endif > diff --git a/test/vinyl/ddl.skipcond b/test/vinyl/ddl.skipcond > new file mode 100644 > index 000000000..ad20eb2b4 > --- /dev/null > +++ b/test/vinyl/ddl.skipcond > @@ -0,0 +1,6 @@ > +# vim: set ft=python : > +import os > + > +# Travis CI fails because of bud #3420 > +if os.environ.get('TRAVIS', False): > + self.skip = 1 Here we can check TRAVIS_JOB_ID. And I guess that non-working http_client.skipcond can be removed now. > -- > 2.18.0 > >
next prev parent reply other threads:[~2018-09-17 18:11 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-17 12:38 Sergei Voronezhskii 2018-09-17 17:42 ` Sergei Voronezhskii 2018-09-17 18:11 ` Alexander Turenko [this message] 2018-09-18 13:47 ` [PATCH v2] " Sergei Voronezhskii 2018-09-19 16:14 ` Alexander Turenko 2018-09-20 8:20 ` Re[2]: " Sergei Voronezhskii 2018-09-21 14:04 ` [tarantool-patches] [PATCH] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180917181119.tbsjrn7ngwd7bmk6@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=sergw@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [tarantool-patches] [PATCH] test: skip ddl test for vinyl on travis' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox