From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] lua: fix assertion failure after improper box.schema.user:passwd() call
Date: Mon, 17 Sep 2018 18:42:56 +0300 [thread overview]
Message-ID: <20180917154256.ujn4jpm56hx2njnp@esperanza> (raw)
In-Reply-To: <B81E047D-2541-4413-AEE3-5951F6E4C1E7@tarantool.org>
On Mon, Sep 17, 2018 at 05:48:53PM +0300, Serge Petrenko wrote:
> diff --git a/src/box/lua/session.c b/src/box/lua/session.c
> index b2e1400b6..7541da0a7 100644
> --- a/src/box/lua/session.c
> +++ b/src/box/lua/session.c
> @@ -201,8 +201,11 @@ lbox_session_su(struct lua_State *L)
> /* Restore the original credentials. */
> fiber_set_user(fiber(), old_credentials);
>
> - if (error)
> + if (error) {
> + luaT_toerror(L);
> luaT_error(L);
> + }
> +
Turns out we can simply use lua_error() instead.
I fixed it and pushed the patch to 1.10.
prev parent reply other threads:[~2018-09-17 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 13:36 Serge Petrenko
2018-09-14 15:17 ` Vladimir Davydov
2018-09-17 14:48 ` Serge Petrenko
2018-09-17 15:42 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917154256.ujn4jpm56hx2njnp@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] lua: fix assertion failure after improper box.schema.user:passwd() call' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox