From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergei Voronezhskii <sergw@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] test: enable parallel mode for wall_off tests
Date: Mon, 17 Sep 2018 16:31:45 +0300 [thread overview]
Message-ID: <20180917133145.vzyvounwxvuclujz@tkn_work_nb> (raw)
In-Reply-To: <20180917131155.8857-1-sergw@tarantool.org>
Adding cleanup option is okay for me, but parallel run still fails and
it is not the time to enable it. I got two failures:
$ cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_BACKTRACE=ON && make -j
$ TEST_RUN_TESTS=$(for i in $(seq 1 100); do echo -n 'wal_off/ '; done) make test
[002] wal_off/lua.test.lua [ fail ]
[002]
[002] Test failed! Result content mismatch:
[002] --- wal_off/lua.result Fri Apr 27 14:25:39 2018
[002] +++ wal_off/lua.reject Mon Sep 17 16:25:40 2018
[002] @@ -91,7 +91,7 @@
[002] ...
[002] mktuple(100000)
[002] ---
[002] -- count 100000 len 368553
[002] +- error: Failed to allocate 368569 bytes in slab allocator for memtx_tuple
[002] ...
[002] space:drop()
[002] ---
[002]
# reproduce file: /home/alex/projects/tarantool-meta/review/tarantool/test/var/reproduce/002_wal_off.list.yaml
---
- [wal_off/tuple.test.lua, null]
- [wal_off/iterator_lt_gt.test.lua, null]
- [wal_off/snapshot_stress.test.lua, null]
- [wal_off/rtree_benchmark.test.lua, null]
- [wal_off/lua.test.lua, null]
[008] wal_off/snapshot_stress.test.lua [ fail ]
[008]
[008] Test failed! Result content mismatch:
[008] --- wal_off/snapshot_stress.result Fri Apr 27 14:25:39 2018
[008] +++ wal_off/snapshot_stress.reject Mon Sep 17 16:25:41 2018
[008] @@ -375,7 +375,7 @@
[008] ...
[008] snaps_find_status;
[008] ---
[008] -- snaps found
[008] +- where are my snapshots?
[008] ...
[008] snapshot_check_failed = false
[008] while #snaps > initial_snap_count do
[008]
# reproduce file: /home/alex/projects/tarantool-meta/review/tarantool/test/var/reproduce/008_wal_off.list.yaml
---
- [wal_off/lua.test.lua, null]
- [wal_off/expirationd.test.lua, null]
- [wal_off/expirationd.test.lua, null]
- [wal_off/wal_mode.test.lua, null]
- [wal_off/func_max.test.lua, null]
- [wal_off/expirationd.test.lua, null]
- [wal_off/snapshot_stress.test.lua, null]
Please, reproduce and elaborate.
BTW, you are forgot the branch name: sergw/enable-parallel-test-wal-off.
WBR, Alexander Turenko.
On Mon, Sep 17, 2018 at 04:11:55PM +0300, Sergei Voronezhskii wrote:
> Use the proper way to cleanup tests.
>
> Part of #2436
> ---
> test/wal_off/oom.result | 4 ++--
> test/wal_off/oom.test.lua | 4 ++--
> test/wal_off/suite.ini | 2 +-
> test/wal_off/tuple.result | 2 +-
> test/wal_off/tuple.test.lua | 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/test/wal_off/oom.result b/test/wal_off/oom.result
> index c47d16c46..65bb8c670 100644
> --- a/test/wal_off/oom.result
> +++ b/test/wal_off/oom.result
> @@ -4,7 +4,7 @@ env = require('test_run')
> test_run = env.new()
> ---
> ...
> -test_run:cmd('restart server default')
> +test_run:cmd('restart server default with cleanup=1')
> test_run:cmd("push filter 'error: Failed to allocate [0-9]+ ' to 'error: Failed to allocate <NUM> '")
> ---
> - true
> @@ -231,7 +231,7 @@ t = nil
> ---
> ...
> -- https://github.com/tarantool/tarantool/issues/962 index:delete() failed
> -test_run:cmd('restart server default')
> +test_run:cmd('restart server default with cleanup=1')
> arena_bytes = box.cfg.memtx_memory
> ---
> ...
> diff --git a/test/wal_off/oom.test.lua b/test/wal_off/oom.test.lua
> index 5c0ab8e73..89dba3f06 100644
> --- a/test/wal_off/oom.test.lua
> +++ b/test/wal_off/oom.test.lua
> @@ -1,6 +1,6 @@
> env = require('test_run')
> test_run = env.new()
> -test_run:cmd('restart server default')
> +test_run:cmd('restart server default with cleanup=1')
> test_run:cmd("push filter 'error: Failed to allocate [0-9]+ ' to 'error: Failed to allocate <NUM> '")
>
> space = box.schema.space.create('tweedledum')
> @@ -80,7 +80,7 @@ space:drop()
> t = nil
>
> -- https://github.com/tarantool/tarantool/issues/962 index:delete() failed
> -test_run:cmd('restart server default')
> +test_run:cmd('restart server default with cleanup=1')
> arena_bytes = box.cfg.memtx_memory
> str = string.rep('a', 15000) -- about size of index memory block
>
> diff --git a/test/wal_off/suite.ini b/test/wal_off/suite.ini
> index ad19eab10..cbb7cb341 100644
> --- a/test/wal_off/suite.ini
> +++ b/test/wal_off/suite.ini
> @@ -2,4 +2,4 @@
> core = tarantool
> script = wal.lua
> description = tarantool/box, wal_mode = none
> -is_parallel = False
> +is_parallel = True
> diff --git a/test/wal_off/tuple.result b/test/wal_off/tuple.result
> index fa431e203..dcbd24daf 100644
> --- a/test/wal_off/tuple.result
> +++ b/test/wal_off/tuple.result
> @@ -4,7 +4,7 @@ env = require('test_run')
> test_run = env.new()
> ---
> ...
> -test_run:cmd("restart server default")
> +test_run:cmd("restart server default with cleanup=1")
> --
> -- Test various tuple bugs which do not require a write ahead log.
> --
> diff --git a/test/wal_off/tuple.test.lua b/test/wal_off/tuple.test.lua
> index 19415a92d..859438f71 100644
> --- a/test/wal_off/tuple.test.lua
> +++ b/test/wal_off/tuple.test.lua
> @@ -1,6 +1,6 @@
> env = require('test_run')
> test_run = env.new()
> -test_run:cmd("restart server default")
> +test_run:cmd("restart server default with cleanup=1")
> --
> -- Test various tuple bugs which do not require a write ahead log.
> --
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-17 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 13:11 [tarantool-patches] " Sergei Voronezhskii
2018-09-17 13:31 ` Alexander Turenko [this message]
2018-09-18 16:10 ` [tarantool-patches] [PATCH v2] " Sergei Voronezhskii
2018-09-19 16:57 ` [tarantool-patches] " Alexander Turenko
2018-09-21 12:44 ` [tarantool-patches] [PATCH] test: enable parallel mode for wal_off tests Sergei Voronezhskii
2018-09-22 1:44 ` Alexander Turenko
2018-09-23 22:40 ` Re[2]: " Sergei Voronezhskii
2018-09-23 22:53 ` [tarantool-patches] " Alexander Turenko
2018-09-25 17:10 ` Vladimir Davydov
2018-09-25 17:44 ` Alexander Turenko
2018-11-27 13:09 ` Re[2]: [PATCH v2] test: enable parallel mode for wall_off tests Sergei Voronezhskii
2018-11-28 14:11 ` [tarantool-patches] Re: [PATCH] " Kirill Yukhin
-- strict thread matches above, loose matches on Subject: below --
2018-09-13 16:30 [tarantool-patches] " Sergei Voronezhskii
2018-09-15 1:13 ` [tarantool-patches] " Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917133145.vzyvounwxvuclujz@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergw@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] test: enable parallel mode for wall_off tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox