Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergei Voronezhskii <sergw@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] test: enable parallel mode for wall_off tests
Date: Sat, 15 Sep 2018 04:13:05 +0300	[thread overview]
Message-ID: <20180915011305.omkpvuyfbjcc2xj4@tkn_work_nb> (raw)
In-Reply-To: <20180913163007.82212-1-sergw@tarantool.org>

Hi!

We look into the problem with Sergei together.

Found failing trace:

- [wal_off/wal_mode.test.lua, null]
- [wal_off/tuple.test.lua, null]
- [wal_off/expirationd.test.lua, null]

wal_mode.test.lua creates a snapshot (it contains space 'tweedledum'),
then tuple.test.lua restarts the default server, it bootstraps from the
snapshot (because WAL is off) and then expirationd.test.lua tries to
create the space again and fails.

The fix:

diff --git a/test/wal_off/tuple.test.lua b/test/wal_off/tuple.test.lua
index 19415a92d..859438f71 100644
--- a/test/wal_off/tuple.test.lua
+++ b/test/wal_off/tuple.test.lua
@@ -1,6 +1,6 @@
 env = require('test_run')
 test_run = env.new()
-test_run:cmd("restart server default")
+test_run:cmd("restart server default with cleanup=1")
 --
 -- Test various tuple bugs which do not require a write ahead log.
 --

WBR, Alexander Turenko.

On Thu, Sep 13, 2018 at 07:30:07PM +0300, Sergei Voronezhskii wrote:
> All tests in one suite must use different spaces, because this can
> cause tests to affect each other.
> 
> Part of #2436
> ---
>  test/wal_off/expirationd.result   | 2 +-
>  test/wal_off/expirationd.test.lua | 2 +-
>  test/wal_off/oom.result           | 2 +-
>  test/wal_off/oom.test.lua         | 2 +-
>  test/wal_off/suite.ini            | 2 +-
>  test/wal_off/wal_mode.result      | 2 +-
>  test/wal_off/wal_mode.test.lua    | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 

  reply	other threads:[~2018-09-15  1:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 16:30 [tarantool-patches] " Sergei Voronezhskii
2018-09-15  1:13 ` Alexander Turenko [this message]
2018-09-17 13:11 Sergei Voronezhskii
2018-09-17 13:31 ` [tarantool-patches] " Alexander Turenko
2018-11-28 14:11 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180915011305.omkpvuyfbjcc2xj4@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=sergw@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] test: enable parallel mode for wall_off tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox