From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Tatunov <n.tatunov@tarantool.org>
Cc: Alex Khatskevich <avkhatskevich@tarantool.org>,
Nikita Pettik <korablev@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool
Date: Tue, 11 Sep 2018 13:11:52 +0300 [thread overview]
Message-ID: <20180911101152.jjfo6zakd37thoxf@tkn_work_nb> (raw)
In-Reply-To: <32D1E5EA-EA21-4E4B-B5F5-80B6578BFBED@tarantool.org>
Hi!
See below.
WBR, Alexandr Turenko.
On Tue, Sep 11, 2018 at 10:38:38AM +0300, Nikita Tatunov wrote:
> Hello, thank you for comments.
> See full diff is at the end of the letter.
>
> >>>>
> >>>> - "ESCAPE expression must be a single character",
> >>>> + "ESCAPE expression must be a"
> >>>> + " single character",
> >>> Do not split error messages at the middle of a sentence. It makes errors ungreppable.
> >>> Make it <80 somehow different.
> >>>
> >>
> >> Have already been discussed in this thread.
> > I suppose that we concluded to try to fit into 80 and split the string only
> > in case it is impossible.
>
> I don’t think so. Anyways, Alexander could you please give your thoughts?
Nikita P. gives key_def.c as the example where we don't create constant
variables in the case. We shouldn't here too I think. At least it should
not be enforced.
next prev parent reply other threads:[~2018-09-11 10:11 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 17:00 [tarantool-patches] [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal N.Tatunov
2018-08-16 17:00 ` [tarantool-patches] [PATCH 1/2] sql: LIKE & GLOB pattern comparison issue N.Tatunov
2018-08-17 9:23 ` [tarantool-patches] " Alex Khatskevich
2018-08-17 11:17 ` Alexander Turenko
2018-08-17 11:42 ` Alex Khatskevich
2018-09-09 13:33 ` Nikita Tatunov
2018-09-10 22:20 ` Alex Khatskevich
2018-09-11 6:06 ` Nikita Tatunov
2018-09-11 10:06 ` Alex Khatskevich
2018-09-11 13:31 ` Nikita Tatunov
2018-10-18 18:02 ` Nikita Tatunov
2018-10-21 3:51 ` Alexander Turenko
2018-10-26 15:19 ` Nikita Tatunov
2018-10-29 13:01 ` Alexander Turenko
2018-10-31 5:25 ` Nikita Tatunov
2018-11-01 10:30 ` Alexander Turenko
2018-11-14 14:16 ` n.pettik
2018-11-14 17:06 ` Alexander Turenko
2018-08-16 17:00 ` [tarantool-patches] [PATCH 2/2] sql: remove GLOB from Tarantool N.Tatunov
2018-08-17 8:25 ` [tarantool-patches] " Alex Khatskevich
2018-08-17 8:49 ` n.pettik
2018-08-17 9:01 ` Alex Khatskevich
2018-08-17 9:20 ` n.pettik
2018-08-17 9:28 ` Alex Khatskevich
[not found] ` <04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru>
2018-08-17 8:53 ` Alex Khatskevich
2018-08-17 11:26 ` Alexander Turenko
2018-08-17 11:34 ` Alexander Turenko
2018-08-17 13:46 ` Nikita Tatunov
2018-09-09 14:57 ` Nikita Tatunov
2018-09-10 22:06 ` Alex Khatskevich
2018-09-11 7:38 ` Nikita Tatunov
2018-09-11 10:11 ` Alexander Turenko [this message]
2018-09-11 10:22 ` Alex Khatskevich
2018-09-11 12:03 ` Alex Khatskevich
2018-10-18 20:28 ` Nikita Tatunov
2018-10-21 3:48 ` Alexander Turenko
2018-10-26 15:21 ` Nikita Tatunov
2018-10-29 12:15 ` Alexander Turenko
2018-11-08 15:09 ` Nikita Tatunov
2018-11-09 12:18 ` Alexander Turenko
2018-11-10 3:38 ` Nikita Tatunov
2018-11-13 19:23 ` Alexander Turenko
2018-11-14 14:16 ` n.pettik
2018-11-14 17:41 ` Alexander Turenko
2018-11-14 21:48 ` n.pettik
2018-11-15 4:57 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911101152.jjfo6zakd37thoxf@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=korablev@tarantool.org \
--cc=n.tatunov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox