* [tarantool-patches] [PATCH] Fix -Werror -Wimplicit-fallthrough build
@ 2018-09-03 16:16 Alexander Turenko
2018-09-05 10:15 ` [tarantool-patches] " Kirill Yukhin
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Turenko @ 2018-09-03 16:16 UTC (permalink / raw)
To: Kirill Yukhin; +Cc: Alexander Turenko, tarantool-patches
-Wimplicit-fallthrough is enabled by -Wextra on GCC 7, so it breaks our
Debug build with this version of the compiler.
Fixes #3658.
---
branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-3658-fix-gcc-7
issue: https://github.com/tarantool/tarantool/issues/3658
src/box/sql/insert.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
index 550514c03..f7d489fe3 100644
--- a/src/box/sql/insert.c
+++ b/src/box/sql/insert.c
@@ -891,6 +891,7 @@ vdbe_emit_constraint_checks(struct Parse *parse_context, struct Table *tab,
switch (on_conflict_nullable) {
case ON_CONFLICT_ACTION_ABORT:
sqlite3MayAbort(parse_context);
+ FALLTHROUGH;
case ON_CONFLICT_ACTION_ROLLBACK:
case ON_CONFLICT_ACTION_FAIL:
err_msg = sqlite3MPrintf(db, "%s.%s", def->name,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tarantool-patches] Re: [PATCH] Fix -Werror -Wimplicit-fallthrough build
2018-09-03 16:16 [tarantool-patches] [PATCH] Fix -Werror -Wimplicit-fallthrough build Alexander Turenko
@ 2018-09-05 10:15 ` Kirill Yukhin
0 siblings, 0 replies; 2+ messages in thread
From: Kirill Yukhin @ 2018-09-05 10:15 UTC (permalink / raw)
To: Alexander Turenko; +Cc: tarantool-patches
Hello,
On 03 сен 19:16, Alexander Turenko wrote:
> -Wimplicit-fallthrough is enabled by -Wextra on GCC 7, so it breaks our
> Debug build with this version of the compiler.
>
> Fixes #3658.
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/Totktonada/gh-3658-fix-gcc-7
> issue: https://github.com/tarantool/tarantool/issues/3658
Checked into 2.0 branch as obvious.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-05 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03 16:16 [tarantool-patches] [PATCH] Fix -Werror -Wimplicit-fallthrough build Alexander Turenko
2018-09-05 10:15 ` [tarantool-patches] " Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox