Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Sergei Kalashnikov <ztarvos@gmail.com>
Cc: tarantool-patches <tarantool-patches@freelists.org>
Subject: Re: [tarantool-patches] [PATCH v2] xlog: add request details to panic message for broken LSN
Date: Wed, 29 Aug 2018 19:31:51 +0300	[thread overview]
Message-ID: <20180829163151.yiwym5ri6y6kmxjf@esperanza> (raw)
In-Reply-To: <20180829152113.GA3636@localhost.localdomain>

On Wed, Aug 29, 2018 at 06:21:15PM +0300, Sergei Kalashnikov wrote:
> > > +dirname = fio.pathjoin(fio.cwd(), "panic")
> > > +xlogs = fio.glob(dirname .. "/*.xlog")
> > > +fio.unlink(xlogs[#xlogs])
> > 
> > I don't understand why you need to delete the last xlog here.
> > 
> 
> This last xlog is always empty, so recovery_scan() skips the vclock_follow()
> call and it doesn't panic unless I delete the file. I'm not sure why it gets
> created since I didn't create checkpoints in the test explicitly. Later on, the
> actual row recovery happens, but recover_xlog() silently skips unordered lsn.

OK, I see. We create an empty xlog on shutdown so that we can find out
the instance vclock on recovery without rescanning the last xlog. This
is needed for replica rebootstrap functionality.

Since recover_xlog() doesn't check LSN order, I guess we could drop
this test case altogether then - anyway, the primary application of
this patch is replication, not local recovery. Well, let's leave it
since it's already implemented and works well.

Thanks for addressing all my comments. I pushed the patch to 1.10.

      reply	other threads:[~2018-08-29 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 11:22 Sergei Kalashnikov
2018-08-27 17:04 ` Vladimir Davydov
2018-08-28 16:27   ` Sergei Kalashnikov
2018-08-29  9:52     ` Vladimir Davydov
2018-08-29 15:21       ` Sergei Kalashnikov
2018-08-29 16:31         ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829163151.yiwym5ri6y6kmxjf@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=ztarvos@gmail.com \
    --subject='Re: [tarantool-patches] [PATCH v2] xlog: add request details to panic message for broken LSN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox