From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@freelists.org, Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org> Subject: Re: [PATCH 1/3] socket: evaluate buffer size in recv / recvfrom Date: Fri, 24 Aug 2018 17:07:59 +0300 [thread overview] Message-ID: <20180824140759.yj7f6aygc7nk6f5g@esperanza> (raw) In-Reply-To: <36b23f07009f3cd467c1eb7e54e982b1f907908d.1535076888.git.alexander.turenko@tarantool.org> On Fri, Aug 24, 2018 at 05:47:37AM +0300, Alexander Turenko wrote: > diff --git a/src/lua/socket.lua b/src/lua/socket.lua > index 06306eae2..946e11e9e 100644 > --- a/src/lua/socket.lua > +++ b/src/lua/socket.lua > @@ -1165,6 +1216,8 @@ socket_mt = { > read = socket_read; > write = socket_write; > send = socket_send; > + is_udp = socket_is_udp; > + dgram_length = socket_dgram_length; I don't think it's a good idea to add these two methods to the public API. Nobody asked for this. Let's please remove them. > recv = socket_recv; > recvfrom = socket_recvfrom; > sendto = socket_sendto;
next prev parent reply other threads:[~2018-08-24 14:07 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-24 2:47 [PATCH 0/3] *** [#3619] socket.recvfrom crops UDP packets *** Alexander Turenko 2018-08-24 2:47 ` [PATCH 1/3] socket: evaluate buffer size in recv / recvfrom Alexander Turenko 2018-08-24 14:07 ` Vladimir Davydov [this message] 2018-08-24 15:25 ` Vladimir Davydov 2018-08-27 0:08 ` Alexander Turenko 2018-08-27 9:20 ` Vladimir Davydov 2018-08-27 9:26 ` Alexander Turenko 2018-08-24 2:47 ` [PATCH 2/3] socket: don't truncate a datagram in recv/recvfrom Alexander Turenko 2018-08-24 15:24 ` Vladimir Davydov 2018-08-24 2:47 ` [PATCH 3/3] socket: prevent recvfrom from returning garbage Alexander Turenko 2018-08-24 13:07 ` Vladimir Davydov 2018-08-24 13:44 ` Alexander Turenko 2018-08-24 13:55 ` Vladimir Davydov 2018-08-24 17:11 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180824140759.yj7f6aygc7nk6f5g@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=alexander.turenko@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=yaroslav.dynnikov@tarantool.org \ --subject='Re: [PATCH 1/3] socket: evaluate buffer size in recv / recvfrom' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox