From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 18/18] vinyl: throttle tx rate if dump does not catch up
Date: Thu, 23 Aug 2018 23:54:43 +0300 [thread overview]
Message-ID: <20180823205443.GF24711@chai> (raw)
In-Reply-To: <c9f4d18f0303dccf0320e89110a62103c54c675c.1534432819.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/08/16 23:03]:
> If the rate at which transactions are ready to write to the database is
> greater than the dump bandwidth, memory will get depleted before the
> last dump is complete and all newer transactions will have to wait until
> the dump has been completed, which may take seconds or even minutes:
Why are you limiting the rate only during a dump? What about
compaction throughtput? Write amplification from compaction is
10x+ times higher than from dump, compaction is actually the main
consumer of disk bandwidth. Shouldn't you throttle writes when
write bandwidth is higher than write amplification/disk bandwidth?
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-08-23 20:54 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 16:11 [PATCH 00/18] Implement write throttling for vinyl Vladimir Davydov
2018-08-16 16:11 ` [PATCH 01/18] vinyl: rework internal quota API Vladimir Davydov
2018-08-20 11:07 ` Konstantin Osipov
2018-08-24 8:32 ` Vladimir Davydov
2018-08-27 18:29 ` Vladimir Davydov
2018-08-16 16:11 ` [PATCH 02/18] vinyl: move quota methods implementation to vy_quota.c Vladimir Davydov
2018-08-20 11:07 ` Konstantin Osipov
2018-08-27 18:30 ` Vladimir Davydov
2018-08-16 16:11 ` [PATCH 03/18] vinyl: move quota related methods and variables from vy_env to vy_quota Vladimir Davydov
2018-08-20 11:08 ` Konstantin Osipov
2018-08-27 18:33 ` Vladimir Davydov
2018-08-16 16:11 ` [PATCH 04/18] vinyl: implement vy_quota_wait using vy_quota_try_use Vladimir Davydov
2018-08-20 11:09 ` Konstantin Osipov
2018-08-27 18:36 ` Vladimir Davydov
2018-08-16 16:11 ` [PATCH 05/18] vinyl: wake up fibers waiting for quota one by one Vladimir Davydov
2018-08-20 11:11 ` Konstantin Osipov
2018-08-24 8:33 ` Vladimir Davydov
2018-08-28 13:19 ` Vladimir Davydov
2018-08-28 14:04 ` Konstantin Osipov
2018-08-28 14:39 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 06/18] vinyl: do not wake up fibers waiting for quota if quota is unavailable Vladimir Davydov
2018-08-20 11:13 ` Konstantin Osipov
2018-08-16 16:12 ` [PATCH 07/18] vinyl: tune dump bandwidth histogram buckets Vladimir Davydov
2018-08-20 11:15 ` Konstantin Osipov
2018-08-28 15:37 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 08/18] vinyl: rename vy_quota::dump_bw to dump_bw_hist Vladimir Davydov
2018-08-20 11:15 ` Konstantin Osipov
2018-08-28 16:04 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 09/18] vinyl: cache dump bandwidth for timer invocation Vladimir Davydov
2018-08-20 11:21 ` Konstantin Osipov
2018-08-28 16:10 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 10/18] vinyl: do not add initial guess to dump bandwidth histogram Vladimir Davydov
2018-08-20 11:23 ` Konstantin Osipov
2018-08-23 20:15 ` Konstantin Osipov
2018-08-28 16:15 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 11/18] vinyl: use snap_io_rate_limit for initial dump bandwidth estimate Vladimir Davydov
2018-08-20 11:24 ` Konstantin Osipov
2018-08-24 8:31 ` Vladimir Davydov
2018-08-28 16:18 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 12/18] histogram: add function for computing lower bound percentile estimate Vladimir Davydov
2018-08-20 11:29 ` [tarantool-patches] " Konstantin Osipov
2018-08-24 8:30 ` Vladimir Davydov
2018-08-28 16:39 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 13/18] vinyl: use lower bound percentile estimate for dump bandwidth Vladimir Davydov
2018-08-28 16:51 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 14/18] vinyl: do not try to trigger dump if it is already in progress Vladimir Davydov
2018-08-16 16:12 ` [PATCH 15/18] vinyl: improve dump start/stop logging Vladimir Davydov
2018-08-23 20:18 ` Konstantin Osipov
2018-08-16 16:12 ` [PATCH 16/18] vinyl: confine quota watermark within sane value range Vladimir Davydov
2018-08-16 16:12 ` [PATCH 17/18] vinyl: set quota timer period to 100 ms Vladimir Davydov
2018-08-23 20:49 ` Konstantin Osipov
2018-08-24 8:18 ` Vladimir Davydov
2018-08-16 16:12 ` [PATCH 18/18] vinyl: throttle tx rate if dump does not catch up Vladimir Davydov
2018-08-23 20:54 ` Konstantin Osipov [this message]
2018-08-23 20:58 ` [tarantool-patches] " Konstantin Osipov
2018-08-24 8:21 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823205443.GF24711@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 18/18] vinyl: throttle tx rate if dump does not catch up' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox