From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] replication: fix exit with ER_NO_SUCH_USER during bootstrap
Date: Thu, 23 Aug 2018 16:29:05 +0300 [thread overview]
Message-ID: <20180823132905.qpye5zntutsmznv2@esperanza> (raw)
In-Reply-To: <20180823125743.56072-1-sergepetrenko@tarantool.org>
On Thu, Aug 23, 2018 at 03:57:43PM +0300, Serge Petrenko wrote:
> When replication is configured via some user created in box.once()
> function and box.once() takes more than replication_timeout seconds
> to execute, appliers recieve ER_NO_SUCH_USER error, which they don't
> handle. This leads to occasional test failures in replication suite.
> Fix this by handling the aforementioned case in applier_f().
>
> Closes #3637
> ---
> https://github.com/tarantool/tarantool/issues/3637
> https://github.com/tarantool/tarantool/tree/sp/gh-3637-replication-tests-fix
>
> src/box/applier.cc | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index dbb4d05f9..740778e80 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -607,6 +607,14 @@ applier_f(va_list ap)
> applier_log_error(applier, e);
> applier_disconnect(applier, APPLIER_DISCONNECTED);
> goto reconnect;
> + } else if (e->errcode() == ER_NO_SUCH_USER) {
> + /*
> + * Probably box.once() hasn't finished
> + * on bootstrap leader yet.
> + */
> + applier_log_error(applier, e);
> + applier_disconnect(applier, APPLIER_DISCONNECTED);
> + goto reconnect;
This piece of code isn't covered by any test, see
https://coveralls.io/builds/18630789/source?filename=src/box/applier.cc#L610
Please add a test case. I think it should be pretty easy to do: start a
replica with a small value of box.cfg.replication_timeout which tries to
connect to the default instance as a non-existent user, then wait a bit,
create the user, and make sure it finally connects.
Also, I think that you should share the code with ER_ACCESS_DENIED
case, because these two errors have the same nature - missing or invalid
configuration:
if (e->errcode() == ER_ACCESS_DENIED ||
e->errcode() == ER_NO_SUCH_USER) {
/* Invalid configuration */
applier_log_error(applier, e);
applier_disconnect(applier, APPLIER_DISCONNECTED);
goto reconnect;
}
prev parent reply other threads:[~2018-08-23 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 12:57 Serge Petrenko
2018-08-23 13:29 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823132905.qpye5zntutsmznv2@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] replication: fix exit with ER_NO_SUCH_USER during bootstrap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox