Re: [PATCH v2] tarantoolctl: return an error on enter to a dead socket.

[Vladimir Davydov <vdavydov.dev@gmail.com>]

On Tue, Aug 21, 2018 at 03:51:57PM +0300, Serge Petrenko wrote:
> >> +-- check enter
> >> +do
> >> +    local dir = fio.tempdir()
> >> +
> >> +    local code = [[ box.cfg{} ]]
> >> +    create_script(dir, 'script.lua', code)
> >> +
> >> +    local status, err = pcall(function()
> >> +        test:test("check error codes in case of enter", function(test_i)
> >> +            test_i:plan(10)
> >> +            check_ok(test_i, dir, 'enter', 'script', 1, nil, "Can't connect to")
> >> +            local console_sock = 'script.control'
> >> +            console_sock = fio.pathjoin(dir, console_sock)
> >> +            test_i:is(fio.path.exists(console_sock), false, "directory clean")
> >> +            check_ok(test_i, dir, 'start', 'script', 0)
> >> +            tctl_wait_start(dir, 'script')
> >> +            test_i:is(fio.path.exists(console_sock), true,
> >> +                      "unix socket created")
> >> +            check_ok(test_i, dir, 'stop', 'script', 0)
> >> +            wait_delete(console_sock)
> > 
> > There's tctl_wait_stop() for this.
> 
> Yes, fixed. New diff is below.
> 
> > 
> > Anyway, why do you need to start/stop instance before trying to enter
> > it? AFAIU you just want to check that 'tarantoolctl enter' returns an
> > error when called on a closed socket so the code below should be enough.
> 
> I wanted to stress that I’m using a correct path to socket. Not just creating some
> Random file at some random place and then expecting `tarantoolctl enter` to fail.
> Also test that there is no socket after `tarantoolctl stop` was a request by Kostja
> For previous patch, but it is irrelevant now. We can remove it, if you want, but
> I believe it’s some extra coverage, nothing wrong with that.

OK, pushed to 1.10.