[tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool

[Alexander Turenko <alexander.turenko@tarantool.org>]

On Fri, Aug 17, 2018 at 02:26:19PM +0300, Alexander Turenko wrote:
> Hi!
> 
> I have one note.
> 
> WBR, Alexander Turenko.
> 
> On Fri, Aug 17, 2018 at 11:25:14AM +0300, Alex Khatskevich wrote:
> > 
> > 
> > >   		if (sqlite3Utf8CharLen((char *)zEsc, -1) != 1) {
> > >   			sqlite3_result_error(context,
> > > -					     "ESCAPE expression must be a single character",
> > > +					     "ESCAPE expression must be a"
> > > +					     " single character",
> > Do not split error messages at the middle of a sentence. It makes errors
> > ungreppable.
> > Make it <80 somehow different.
> > 
> 
> It was my thought that such rule should be enforced. But I asks Vladimir
> D. and he says that kernel developers don't care about that and show me
> examples.
> 
> Anyway, how you would propose to avoid the string splitting here?
> 
> > > -		sqlite3_result_error(context, "LIKE or GLOB pattern can only"
> > > -				     " contain UTF-8 characters", -1);
> > > +		sqlite3_result_error(context, "LIKE pattern can only contain"
> > > +				     " UTF-8 characters", -1);
> > Do not split error messages at the middle of a sentence. Make it <80 somehow
> > different.
> 
> Same here.
> 

Sorry, missed the following discussion.

If you think we should change our code style, please review it with
mantainers first. But as I said above we already have this point
discussed.

WBR, Alexander Turenko.