From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Alex Khatskevich <avkhatskevich@tarantool.org>
Cc: Nikita Tatunov <n.tatunov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 1/2] sql: LIKE & GLOB pattern comparison issue
Date: Thu, 16 Aug 2018 15:58:17 +0300 [thread overview]
Message-ID: <20180816125817.roi3xzrr7elfqyl7@tkn_work_nb> (raw)
In-Reply-To: <dcec2845-3380-1094-542c-41590900efba@tarantool.org>
Hi!
On Wed, Aug 15, 2018 at 11:50:48AM +0300, Alex Khatskevich wrote:
> Fist of all you did something wrong with the cover letter of this patchset.
> Commit messages should be sent as replies to the cover letter.
>
> Second, this commit should be rebased on top of the `glob deletion`.
>
> Please, rebase and send this patch properly and we continue review process.
The rebase was estimated as approximately one working day of work, so I
think it is not worth to do.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2018-08-16 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 16:47 [tarantool-patches] [PATCH v2 0/2] sql: pattern comparison fixes & GLOB removal N.Tatunov
[not found] ` <cover.1534259951.git.n.tatunov@tarantool.org>
2018-08-14 16:47 ` [tarantool-patches] [PATCH v2 1/2] sql: LIKE & GLOB pattern comparison issue N.Tatunov
2018-08-15 8:50 ` [tarantool-patches] " Alex Khatskevich
2018-08-16 12:58 ` Alexander Turenko [this message]
2018-08-14 16:47 ` [tarantool-patches] [PATCH v2 2/2] sql: remove GLOB from Tarantool N.Tatunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816125817.roi3xzrr7elfqyl7@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avkhatskevich@tarantool.org \
--cc=n.tatunov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/2] sql: LIKE & GLOB pattern comparison issue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox