From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <krishtal.olja@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] box-tap: add test to check log_nonblock mode
Date: Mon, 13 Aug 2018 13:20:15 +0300 [thread overview]
Message-ID: <20180813102015.ejyjs6uvfhmlqrfm@esperanza> (raw)
In-Reply-To: <20180813071208.40972-1-krishtal.olja@gmail.com>
On Mon, Aug 13, 2018 at 10:12:08AM +0300, Olga Arkhangelskaia wrote:
> We should test log_nonblock mode. In some cases the loss of this flag
> leads to tarantool hanging forever (centos/fedora 26/27).
> This tests checks such possibility.
>
> Closes #3615
> ---
> https://github.com/tarantool/tarantool/issues/3615
> https://github.com/tarantool/tarantool/tree/OKriw/gh-3615-test-for-hanging-1.10
The test passes even without the patch that fixes log_nonblock behavior.
Please make sure it doesn't.
Also 'box-tap' is a wrong prefix. The subsystem you're patching is
called 'test'. Please fix.
next prev parent reply other threads:[~2018-08-13 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 7:12 Olga Arkhangelskaia
2018-08-13 10:20 ` Vladimir Davydov [this message]
[not found] ` <CAG9q7EpeeZqcqAFb9Og6koC1pMHVdD6jiV3vG7g=Oss82YcE3A@mail.gmail.com>
2018-08-13 12:01 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813102015.ejyjs6uvfhmlqrfm@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=krishtal.olja@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] box-tap: add test to check log_nonblock mode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox