From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v1 1/1] box: fix crash in ncurses on fedora 28
Date: Wed, 8 Aug 2018 21:27:44 +0300 [thread overview]
Message-ID: <20180808182744.fa5ijh425oipk7fj@esperanza> (raw)
In-Reply-To: <eb5323504261a57a84fa99e8072a89c8c919e1d7.1533736169.git.kshcherbatov@tarantool.org>
On Wed, Aug 08, 2018 at 04:52:28PM +0300, Kirill Shcherbatov wrote:
> diff --git a/src/lua/init.c b/src/lua/init.c
> index a0a7f63..217640f 100644
> --- a/src/lua/init.c
> +++ b/src/lua/init.c
> @@ -610,8 +610,10 @@ tarantool_lua_run_script(char *path, bool interactive,
> * To work this problem around we must run init script in
> * a separate fiber.
> */
> -
> - script_fiber = fiber_new(title, run_script_f);
> + struct fiber_attr fiber_attr =
> + {.stack_size = 0x8000 * 4,
> + .flags = FIBER_DEFAULT_FLAGS | FIBER_CUSTOM_STACK};
> + script_fiber = fiber_new_ex(title, &fiber_attr, run_script_f);
AFAIU lbox_console_readline (the function that calls ncurses and crashes
according to the ticket description) can be called from other fibers as
well, e.g.
require('fiber').create(function() require('console').start() end)
Don't we want to fix that too?
next prev parent reply other threads:[~2018-08-08 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 13:52 Kirill Shcherbatov
2018-08-08 18:27 ` Vladimir Davydov [this message]
2018-08-15 18:15 ` [tarantool-patches] " Kirill Shcherbatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808182744.fa5ijh425oipk7fj@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v1 1/1] box: fix crash in ncurses on fedora 28' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox