Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Krishtal <krishtal.olja@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v7] Configurable syslog destination
Date: Wed, 8 Aug 2018 14:23:21 +0300	[thread overview]
Message-ID: <20180808112321.cgc2u35i6vmieiyn@esperanza> (raw)
In-Reply-To: <CAG9q7Ep+VfJEOjgsPbnpt2W-oNnOaVgd=TMJbzUknL3W=RhSow@mail.gmail.com>

On Wed, Aug 08, 2018 at 01:40:34PM +0300, Olga Krishtal wrote:
> > > +-- make sure that socket would not block
> > > +while unix_socket:readable(1) do
> >
> > This timeout is way too long. It will increase the test run time by
> > 1 second. Plus 1 second per each socket.readable call below, that is
> > 4 seconds in total.
> >
> > We strive to make our tests run faster whenever possible. AFAIU you
> > don't need to wait for that long. A timeout of say 1 ms (0.001) should
> > do just fine. Please fix the timeout and re-push the test. No need to
> > resend the patch - just reply to this email once you're done.
> >
> >
> 
> Done
> Have pushed branch
> 
> OKriw/gh-3487-syslog-conf-dest-1.10

Please don't drop the mailing list from Cc (use Reply-All).

Also, I suspect that you use GMail web interface. Please don't
as it mangles patches, just like Mail.ru. Use Thunderbird.

Also, you forgot to add 'Closes #3487'. I added it, don't bother.

Also, there were trailing spaces I didn't notice during review:

> +unix_socket:close()                                                         
> +os.remove(path) 

I removed them this time. In order not to miss trailing spaces in
future, please add the following two lines to your .gitconfig:

[color]
	ui = true

(it will make git show/diff highlight trailing spaces)

I pushed the patch to 1.10. Please open a ticket for documentation.
In future write feature documentation requests right in the commit
message (see @TarantoolBot).

      parent reply	other threads:[~2018-08-08 11:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 20:16 Olga Arkhangelskaia
2018-08-08  9:00 ` Vladimir Davydov
     [not found]   ` <CAG9q7Ep+VfJEOjgsPbnpt2W-oNnOaVgd=TMJbzUknL3W=RhSow@mail.gmail.com>
2018-08-08 11:23     ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180808112321.cgc2u35i6vmieiyn@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=krishtal.olja@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v7] Configurable syslog destination' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox