From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: Kirill Yukhin <kyukhin@tarantool.org>, tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] replication: fix a failing assert in replica_on_applier_disconnect()
Date: Wed, 8 Aug 2018 13:58:31 +0300 [thread overview]
Message-ID: <20180808105830.razslkg6whxzbcvq@esperanza> (raw)
In-Reply-To: <51F21380-A795-4F40-B3DE-A9770B190BD6@tarantool.org>
On Wed, Aug 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote:
>
>
> > 7 авг. 2018 г., в 19:50, Vladimir Davydov <vdavydov.dev@gmail.com> написал(а):
> >
> > On Mon, Aug 06, 2018 at 05:14:05PM +0300, Sergey Petrenko wrote:
> >> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua
> >> index c05e52165..27c1a4821 100644
> >> --- a/test/replication/misc.test.lua
> >> +++ b/test/replication/misc.test.lua
> >> @@ -81,3 +81,15 @@ test_run:cmd("switch default")
> >> test_run:drop_cluster(SERVERS)
> >>
> >> box.schema.user.revoke('guest', 'replication')
> >> +
> >> +-- gh-3510 assertion failure in replica_on_applier_disconnect()
> >> +test_run:cmd('create server er_load1 with script="replication/er_load1.lua"')
> >> +test_run:cmd('create server er_load2 with script="replication/er_load2.lua"')
> >> +test_run:cmd('start server er_load1 with wait=False, wait_load=False')
> >> +test_run:cmd('start server er_load2 with wait=False, wait_load=False')
> >> +require('fiber').sleep(0.5)
> >> +test_run:cmd('stop server er_load1')
> >> +require('fiber').sleep(1)
> >
> > <kostja-mode>
> > These sleep()'s are way too long. They will make our tests run forever.
> > Please change to 0.00001 or smaller or rewrite the test so that you do
> > not need them.
> > </kostja-mode>
>
> Hi! Thank you for review.
> Fixed. Here’s the new diff:
>
> src/box/replication.cc | 4 ++++
> test/replication/er_load.lua | 25 +++++++++++++++++++++++++
> test/replication/er_load1.lua | 1 +
> test/replication/er_load2.lua | 1 +
> test/replication/misc.result | 32 ++++++++++++++++++++++++++++++++
> test/replication/misc.test.lua | 12 ++++++++++++
> 6 files changed, 75 insertions(+)
> create mode 100644 test/replication/er_load.lua
> create mode 120000 test/replication/er_load1.lua
> create mode 120000 test/replication/er_load2.lua
>
With your patch replication/on_replace test hangs on Travis CI for
test/coverage targets (I tried to restart, but it doesn't help).
Actually, it hangs on my local machine too (debug build). Please fix.
next prev parent reply other threads:[~2018-08-08 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 5:59 Serge Petrenko
2018-08-03 15:43 ` Vladimir Davydov
2018-08-03 15:57 ` [tarantool-patches] " Kirill Yukhin
2018-08-06 14:14 ` Sergey Petrenko
2018-08-07 16:50 ` Vladimir Davydov
2018-08-08 10:10 ` Sergey Petrenko
2018-08-08 10:58 ` Vladimir Davydov [this message]
2018-08-08 15:19 ` Sergey Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808105830.razslkg6whxzbcvq@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] replication: fix a failing assert in replica_on_applier_disconnect()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox