Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
	Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] Increase time quota for selectG test on vinyl
Date: Fri, 3 Aug 2018 18:23:29 +0300	[thread overview]
Message-ID: <20180803152329.lqudiu6ypq3po32b@tkn_work_nb> (raw)
In-Reply-To: <F8741278-3514-4703-9CF4-1F5E807F5D3D@tarantool.org>

Thanks for the review!

I had rebased the patch on top of current 2.0 and had updated the commit
headers as you suggested.

Kirill asks me to put a link to an issue, so it is here:

https://github.com/tarantool/tarantool/issues/3590

Kirill, can you review the patch?

WBR, Alexander Turenko.

On Fri, Aug 03, 2018 at 04:57:56PM +0300, n.pettik wrote:
> LGTM, but AFAIK we should use prefix for module given commit relates to.
> In our case it would be (I guess, since it is SQL test):
> sql: increase time quota ...
> 

  reply	other threads:[~2018-08-03 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 20:22 [tarantool-patches] " Alexander Turenko
2018-08-03 13:57 ` [tarantool-patches] " n.pettik
2018-08-03 15:23   ` Alexander Turenko [this message]
2018-08-03 15:38 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180803152329.lqudiu6ypq3po32b@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] Increase time quota for selectG test on vinyl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox