From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] Configurable syslog destination
Date: Thu, 2 Aug 2018 15:27:28 +0300 [thread overview]
Message-ID: <20180802122728.ramd5n4nmuxuziuw@esperanza> (raw)
In-Reply-To: <20180802074210.34945-1-arkholga@tarantool.org>
On Thu, Aug 02, 2018 at 10:42:10AM +0300, Olga Arkhangelskaia wrote:
> Added server option to syslog configuration.
> Server option is responsible for log destination. At the momemt
> there is two ways of usage:server=unix:/path/to/socket or
> server=ipv4:port. If port is not set default udp port 514 is used.
> If logging to syslog is set, however there is no server options -
> default location is used: Linux /dev/log and Mac /var/run/syslog.
>
> Closes #3487
> ---
> https://github.com/tarantool/tarantool/issues/3487
> https://github.com/tarantool/tarantool/tree/OKriw/gh-3487-syslog-conf-dest
Wrong branch. Should be
https://github.com/tarantool/tarantool/tree/OKriw/gh-3487-syslog-conf-dest-1.10
The patch looks good to me, but it doesn't pass tests on Travis CI
(hangs on EL7, Fedora 26, 27):
https://travis-ci.org/tarantool/tarantool/builds/410947239?utm_source=github_status&utm_medium=notification
Please fix. Unfortunately test-run doesn't report anything if a test
hangs. I filed a ticket for that:
https://github.com/tarantool/test-run/issues/106
First, you need to identify a problem. To do that, you can try to run
tests in Docker, like Travis does.
prev parent reply other threads:[~2018-08-02 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 7:42 Olga Arkhangelskaia
2018-08-02 12:27 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802122728.ramd5n4nmuxuziuw@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] Configurable syslog destination' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox