From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v5 2/4] box-tap: test valid log configuration
Date: Wed, 1 Aug 2018 15:52:19 +0300 [thread overview]
Message-ID: <20180801125219.ydwnn2jorhw3ebbj@esperanza> (raw)
In-Reply-To: <20180731171519.74073-3-arkholga@tarantool.org>
This test fails on Travis CI. Looks like syslog daemon blocks
connections for some reason. I don't think it's worth investigating,
because you test syslog configuration in patches 3 and 4 anyway.
Let's just drop it?
On Tue, Jul 31, 2018 at 08:15:17PM +0300, Olga Arkhangelskaia wrote:
> Test case checks that valid log configuration is not broken.
>
> In scope of gh-3487
> ---
> test/box-tap/cfg.test.lua | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index ffafdbe42..67e4c3af9 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket = require('socket')
> local fio = require('fio')
> local uuid = require('uuid')
> local msgpack = require('msgpack')
> -test:plan(95)
> +test:plan(96)
>
> --------------------------------------------------------------------------------
> -- Invalid values
> @@ -464,5 +464,13 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new())
> test:is(run_script(code), PANIC, "replicaset_uuid mismatch")
> fio.rmdir(dir)
>
> +--
> +-- Check syslog configuration
> +-- (syslog daemon may be not started hence use pcall)
> +--
> +code = [[pcall(box.cfg, {log = 'syslog:identity=tarantool'})
> +]]
> +test:is(run_script(code), 0, "syslog log configuration")
> +
> test:check()
> os.exit(0)
> --
> 2.14.3 (Apple Git-98)
>
>
next prev parent reply other threads:[~2018-08-01 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 17:15 [tarantool-patches] [PATCH v5 0/4] Syslog destination Olga Arkhangelskaia
2018-07-31 17:15 ` [tarantool-patches] [PATCH v5 1/4] Configurable syslog destination Olga Arkhangelskaia
2018-08-01 12:45 ` Vladimir Davydov
2018-07-31 17:15 ` [tarantool-patches] [PATCH v5 2/4] box-tap: test valid log configuration Olga Arkhangelskaia
2018-08-01 12:52 ` Vladimir Davydov [this message]
2018-07-31 17:15 ` [tarantool-patches] [PATCH v5 3/4] box-tap: syslog destination test unix socket Olga Arkhangelskaia
2018-07-31 17:15 ` [tarantool-patches] [PATCH v5 4/4] box-tap:syslog remote destination test Olga Arkhangelskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801125219.ydwnn2jorhw3ebbj@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v5 2/4] box-tap: test valid log configuration' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox