Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH v2 2/2] box-tap: test to check logger invalid config.
Date: Wed, 1 Aug 2018 15:39:57 +0300	[thread overview]
Message-ID: <20180801123957.ernpjs7cnhef54co@esperanza> (raw)
In-Reply-To: <20180801110710.10292-3-arkholga@tarantool.org>

On Wed, Aug 01, 2018 at 02:07:10PM +0300, Olga Arkhangelskaia wrote:
> Added test to check that logger doesn't except invalid
> configuration.
> 
> In scope of gh-3553
> ---
>  test/box-tap/cfg.test.lua | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

We don't submit tests separately. Please squash this patch in patch 1.

You also changed the way box.cfg{log_format=...} works when called
after initial configuration: now it returns an error if the format is
incompatible with the logger type. Please add a test case for this, too.

> 
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index ea6f4d646..2d77c9f3e 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket = require('socket')
>  local fio = require('fio')
>  local uuid = require('uuid')
>  local msgpack = require('msgpack')
> -test:plan(95)
> +test:plan(98)
>  
>  --------------------------------------------------------------------------------
>  -- Invalid values
> @@ -39,6 +39,8 @@ invalid('listen', '//!')
>  invalid('log', ':')
>  invalid('log', 'syslog:xxx=')
>  invalid('log_level', 'unknown')
> +invalid('log_format', "xxx")
> +invalid('log', ":test:")
>  invalid('vinyl_memory', -1)
>  invalid('vinyl_read_threads', 0)
>  invalid('vinyl_write_threads', 1)
> @@ -56,6 +58,7 @@ end
>  
>  invalid_combinations("log, log_nonblock", {log = "1.log", log_nonblock = true})
>  invalid_combinations("log, log_format", {log = "syslog:identity=tarantool", log_format = 'json'})
> +invalid_combinations("log, log_nonblock", {log_nonblock = true})
>  
>  test:is(type(box.cfg), 'function', 'box is not started')

      reply	other threads:[~2018-08-01 12:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 11:07 [tarantool-patches] [PATCH v2 0/2] logger non inf error Olga Arkhangelskaia
2018-08-01 11:07 ` [tarantool-patches] [PATCH v2 1/2] Fixed non-informative error messages for log conf Olga Arkhangelskaia
2018-08-01 12:32   ` Vladimir Davydov
2018-08-01 11:07 ` [tarantool-patches] [PATCH v2 2/2] box-tap: test to check logger invalid config Olga Arkhangelskaia
2018-08-01 12:39   ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801123957.ernpjs7cnhef54co@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=arkholga@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2 2/2] box-tap: test to check logger invalid config.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox