From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions
Date: Tue, 31 Jul 2018 23:38:13 +0300 [thread overview]
Message-ID: <20180731203813.GF15235@chai> (raw)
In-Reply-To: <1542cec64f8dc936a7cf09a33ca3964f1297c3b0.1531065648.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/07/08 22:53]:
> This is not necessary, as we can use fiber()->gc, as we usually do.
The reason Vlad is passing it explicitly is that if we plan to
make transactions interactive, we're going to end up with more
than one transaction per fiber. So it really should be tx->gc
(non-existent at the moment), not fiber->gc.
I think Vlad is passing it around explicitly as a mental note to
self.
It's OK to push.
1.0
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-07-31 20:38 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 16:48 [RFC PATCH 02/23] vinyl: always get full tuple from pk after reading from secondary index Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 00/23] vinyl: eliminate read on REPLACE/DELETE Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 01/23] vinyl: do not turn REPLACE into INSERT when processing DML request Vladimir Davydov
2018-07-10 12:15 ` Konstantin Osipov
2018-07-10 12:19 ` Vladimir Davydov
2018-07-10 18:39 ` Konstantin Osipov
2018-07-11 7:57 ` Vladimir Davydov
2018-07-11 10:25 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 03/23] vinyl: use vy_mem_iterator for point lookup Vladimir Davydov
2018-07-17 10:14 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 04/23] vinyl: make point lookup always return the latest tuple version Vladimir Davydov
2018-07-10 16:19 ` Konstantin Osipov
2018-07-10 16:43 ` Vladimir Davydov
2018-07-11 16:33 ` Vladimir Davydov
2018-07-31 19:17 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 05/23] vinyl: fold vy_replace_one and vy_replace_impl Vladimir Davydov
2018-07-31 20:28 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 06/23] vinyl: fold vy_delete_impl Vladimir Davydov
2018-07-31 20:28 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 07/23] vinyl: refactor unique check Vladimir Davydov
2018-07-31 20:28 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 08/23] vinyl: check key uniqueness before modifying tx write set Vladimir Davydov
2018-07-31 20:34 ` Konstantin Osipov
2018-08-01 10:42 ` Vladimir Davydov
2018-08-09 20:26 ` Konstantin Osipov
2018-08-10 8:26 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 09/23] vinyl: remove env argument of vy_check_is_unique_{primary,secondary} Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 10/23] vinyl: store full tuples in secondary index cache Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 11/23] xrow: allow to store flags in DML requests Vladimir Davydov
2018-07-31 20:36 ` Konstantin Osipov
2018-08-01 14:10 ` Vladimir Davydov
2018-08-17 13:34 ` Vladimir Davydov
2018-08-17 13:34 ` [PATCH 1/2] xrow: allow to store tuple metadata in request Vladimir Davydov
2018-08-17 13:34 ` [PATCH 2/2] vinyl: introduce statement flags Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions Vladimir Davydov
2018-07-17 10:16 ` Vladimir Davydov
2018-07-31 20:38 ` Konstantin Osipov [this message]
2018-08-01 14:14 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 13/23] vinyl: fix potential use-after-free in vy_read_view_merge Vladimir Davydov
2018-07-17 10:16 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 14/23] test: unit/vy_write_iterator: minor refactoring Vladimir Davydov
2018-07-17 10:17 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 15/23] vinyl: teach write iterator to return overwritten tuples Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 16/23] vinyl: allow to skip certain statements on read Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 17/23] vinyl: do not free pending tasks on shutdown Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 18/23] vinyl: store pointer to scheduler in struct vy_task Vladimir Davydov
2018-07-31 20:39 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 19/23] vinyl: rename some members of vy_scheduler and vy_task struct Vladimir Davydov
2018-07-31 20:40 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 20/23] vinyl: use cbus for communication between scheduler and worker threads Vladimir Davydov
2018-07-31 20:43 ` Konstantin Osipov
2018-08-01 14:26 ` Vladimir Davydov
2018-07-08 16:48 ` [RFC PATCH 21/23] vinyl: zap vy_scheduler::is_worker_pool_running Vladimir Davydov
2018-07-31 20:43 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 22/23] vinyl: rename vy_task::status to is_failed Vladimir Davydov
2018-07-31 20:44 ` Konstantin Osipov
2018-07-08 16:48 ` [RFC PATCH 23/23] vinyl: eliminate read on REPLACE/DELETE Vladimir Davydov
2018-07-13 10:53 ` Vladimir Davydov
2018-07-13 10:53 ` [PATCH 1/3] stailq: add stailq_insert function Vladimir Davydov
2018-07-15 7:02 ` Konstantin Osipov
2018-07-15 13:17 ` Vladimir Davydov
2018-07-15 18:40 ` Konstantin Osipov
2018-07-17 10:18 ` Vladimir Davydov
2018-07-13 10:53 ` [PATCH 2/3] vinyl: link all indexes of the same space Vladimir Davydov
2018-07-13 10:53 ` [PATCH 3/3] vinyl: generate deferred DELETEs on tx commit Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731203813.GF15235@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox