From: Kirill Yukhin <kyukhin@tarantool.org>
To: v.shpilevoy@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: remove pragma schema_version
Date: Tue, 31 Jul 2018 13:56:33 +0300 [thread overview]
Message-ID: <20180731105633.o5aco7usbtva6iqr@tarantool.org> (raw)
In-Reply-To: <836ab78c9ea4741455b7c8c226bd7919f635af6f.1533034378.git.kyukhin@tarantool.org>
On 31 июл 13:54, Kirill Yukhin wrote:
> This pragma is dead and produces nothing else but segfault.
> Along w/ this pragma, remove now dead opcodes which set/read
> schema_version and all related routines.
> Also, improve opcode generation script.
>
> Part of #3541
> ---
> Branch: https://github.com/tarantool/tarantool/commits/kyukhin/gh-3541-remove-schema-version-pragma
> Issue: https://github.com/tarantool/tarantool/issues/3541
Removed junk
modified src/box/sql/vdbe.c
modified src/box/sql/vdbe.c
@@ -3079,7 +3079,7 @@ case OP_TTransaction: {
/* Opcode: OpenRead P1 P2 P3 P4 P5
* Synopsis: index id = P2, space ptr = P4
*
-\ * Open a cursor for a space specified by pointer in P4 and index
+ * Open a cursor for a space specified by pointer in P4 and index
* id in P2. Give the new cursor an identifier of P1. The P1
* values need not be contiguous but all P1 values should be
* small integers. It is an error for P1 to be negative.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2018-07-31 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 10:54 [tarantool-patches] " Kirill Yukhin
2018-07-31 10:56 ` Kirill Yukhin [this message]
2018-07-31 12:33 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-31 13:20 ` Kirill Yukhin
2018-08-01 11:30 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731105633.o5aco7usbtva6iqr@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove pragma schema_version' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox