From: Konstantin Osipov <kostja@tarantool.org> To: tarantool-patches@freelists.org Cc: Konstantin Belyavskiy <k.belyavskiy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH] lua: fix fio.rmtree to work with non empty dirs Date: Fri, 27 Jul 2018 00:32:11 +0300 [thread overview] Message-ID: <20180726213211.GA18822@chai> (raw) In-Reply-To: <20180718034344.tolxqd4nb3o5bafq@tkn_work_nb> * Alexander Turenko <alexander.turenko@tarantool.org> [18/07/18 09:46]: > Hi Kostya! > > The patch looks good for me except one tiny comment. > I pushed an updated patch (it was not sent to this list), but contains a fix for this review comment. > WBR, Alexander Turenko. > > > index 0850413d9..14e0fb72c 100644 > > --- a/test/app/fio.test.lua > > +++ b/test/app/fio.test.lua > > @@ -131,6 +131,13 @@ fio.rmdir(dir2) > > > > { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) } > > { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3), fio.unlink(file4) } > > + > > +-- gh-3258 rmtree should remove directories with files > > +fio.mktree('tmp2/tmp3/tmp4') > > +fh = fio.open('tmp2/tmp3/tmp4/tmp.txt', {'O_RDWR', 'O_CREAT'}) > > +fh:close() > > +fio.rmtree('tmp2') > > + > > I think it would be good to check that the directory really disappears > (via fio.listdir()). -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
prev parent reply other threads:[~2018-07-26 21:32 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-16 16:15 [tarantool-patches] " Konstantin Belyavskiy 2018-07-18 3:43 ` [tarantool-patches] " Alexander Turenko 2018-07-23 17:27 ` [tarantool-patches] Re[2]: [tarantool-patches] " Konstantin Belyavskiy 2018-07-24 9:28 ` [tarantool-patches] Re: Re[2]: " Alexander Turenko 2018-07-26 21:32 ` Konstantin Osipov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180726213211.GA18822@chai \ --to=kostja@tarantool.org \ --cc=k.belyavskiy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH] lua: fix fio.rmtree to work with non empty dirs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox