Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] Re: Re[2]: [PATCH] add FindICONV and iconv wrapper
Date: Tue, 24 Jul 2018 19:54:04 +0300	[thread overview]
Message-ID: <20180724165404.n2m2djbikalosoav@tarantool.org> (raw)
In-Reply-To: <1532443175.97240990@f404.i.mail.ru>

Hello,
On 24 июл 17:39, Konstantin Belyavskiy wrote:
> Georgy, thank you for the review.
> Please take a look at updated patch. List of changes:
> - update wrong comment
> - rename file and functions iconv_wrap* to tnt_iconv*
> - remove unnecessary include file
Could you pls attach an updated patch in future mails?

--
Regards, Kirill Yukhin

      reply	other threads:[~2018-07-24 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 16:50 [tarantool-patches] " Konstantin Belyavskiy
2018-07-23 13:17 ` [tarantool-patches] " Georgy Kirichenko
2018-07-24 14:39   ` [tarantool-patches] Re[2]: [tarantool-patches] " Konstantin Belyavskiy
2018-07-24 16:54     ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724165404.n2m2djbikalosoav@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: Re[2]: [PATCH] add FindICONV and iconv wrapper' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox