From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: Re[2]: [PATCH] lua: fix fio.rmtree to work with non empty dirs
Date: Tue, 24 Jul 2018 12:28:42 +0300 [thread overview]
Message-ID: <20180724092842.5zi37lk7odkkxnro@tkn_work_nb> (raw)
In-Reply-To: <1532366867.279948629@f221.i.mail.ru>
Hi,
LGTM.
WBR, Alexander Turenko.
On Mon, Jul 23, 2018 at 08:27:47PM +0300, Konstantin Belyavskiy wrote:
> Thanks for review, now check directory absence with fio.stat()
>
> Среда, 18 июля 2018, 6:43 +03:00 от Alexander Turenko
> <alexander.turenko@tarantool.org>:
>
> Hi Kostya!
> The patch looks good for me except one tiny comment.
> WBR, Alexander Turenko.
> > index 0850413d9..14e0fb72c 100644
> > --- a/test/app/fio.test.lua
> > +++ b/test/app/fio.test.lua
> > @@ -131,6 +131,13 @@ fio.rmdir(dir2)
> >
> > { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3),
> fio.unlink(file4) }
> > { fio.unlink(file1), fio.unlink(file2), fio.unlink(file3),
> fio.unlink(file4) }
> > +
> > +-- gh-3258 rmtree should remove directories with files
> > +fio.mktree('tmp2/tmp3/tmp4')
> > +fh = fio.open('tmp2/tmp3/tmp4/tmp.txt', {'O_RDWR', 'O_CREAT'})
> > +fh:close()
> > +fio.rmtree('tmp2')
> > +
> I think it would be good to check that the directory really disappears
> (via fio.listdir()).
>
> Best regards,
> Konstantin Belyavskiy
> k.belyavskiy@tarantool.org
next prev parent reply other threads:[~2018-07-24 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 16:15 [tarantool-patches] " Konstantin Belyavskiy
2018-07-18 3:43 ` [tarantool-patches] " Alexander Turenko
2018-07-23 17:27 ` [tarantool-patches] Re[2]: [tarantool-patches] " Konstantin Belyavskiy
2018-07-24 9:28 ` Alexander Turenko [this message]
2018-07-26 21:32 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724092842.5zi37lk7odkkxnro@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=k.belyavskiy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: Re[2]: [PATCH] lua: fix fio.rmtree to work with non empty dirs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox