Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH] replication: unregister replica with gc if deleted from cluster
Date: Tue, 24 Jul 2018 11:37:01 +0300	[thread overview]
Message-ID: <20180724083701.hpibyh54jf35wd6r@esperanza> (raw)
In-Reply-To: <20180723203019.GE10149@chai>

On Mon, Jul 23, 2018 at 11:30:19PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/07/23 00:34]:
> 
> > When a replica is removed from the cluster table, the corresponding
> > replica struct isn't destroyed unless both the relay and the applier
> > attached to it are stopped, see replica_clear_id(). Since replica struct
> > is a holder of the garbage collection state, this means that in case an
> > evicted replica has an applier or a relay that fails to exit for some
> > reason, garbage collection will hang.
> 
> I failed to merge this into 1.10, please help.

Done.

      reply	other threads:[~2018-07-24  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-22 19:27 Vladimir Davydov
2018-07-23 20:30 ` [tarantool-patches] " Konstantin Osipov
2018-07-24  8:37   ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724083701.hpibyh54jf35wd6r@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH] replication: unregister replica with gc if deleted from cluster' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox