From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 5/6] space: call before_replace trigger even if space has no indexes
Date: Sat, 21 Jul 2018 15:26:52 +0300 [thread overview]
Message-ID: <20180721122652.rll2tshmcsbhzsfn@esperanza> (raw)
In-Reply-To: <20180720183909.GF4827@chai>
On Fri, Jul 20, 2018 at 09:39:09PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/07/20 20:45]:
> > Needed for blackhole spaces (see the next patch), which don't support
> > indexes per se, but still may have a before_replace trigger installed.
>
> Why do you need to enable before replace triggers for blackhole?
Why not? before_replace can be installed on a blackhole space so
I guess it should work, otherwise it may raise questions.
> What's wrong with on_replace triggers?
Nothing wrong at all. They work as well.
next prev parent reply other threads:[~2018-07-21 12:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 17:43 [PATCH 0/6] Introduce blackhole engine Vladimir Davydov
2018-07-20 17:43 ` [PATCH 1/6] Add generic engine, space, index method stubs Vladimir Davydov
2018-07-20 17:56 ` Konstantin Osipov
2018-07-21 12:24 ` Vladimir Davydov
2018-07-20 17:43 ` [PATCH 2/6] Merge sysview_index.[hc] and sysview_engine.[hc] Vladimir Davydov
2018-07-20 18:02 ` Konstantin Osipov
2018-07-21 12:24 ` Vladimir Davydov
2018-07-20 17:43 ` [PATCH 3/6] Rework memtx replace function Vladimir Davydov
2018-07-20 18:04 ` Konstantin Osipov
2018-07-21 12:24 ` Vladimir Davydov
2018-07-20 17:43 ` [PATCH 4/6] txn: unify txn_stmt tuples reference counting rules Vladimir Davydov
2018-07-20 18:31 ` Konstantin Osipov
2018-07-21 12:24 ` Vladimir Davydov
2018-07-20 17:43 ` [PATCH 5/6] space: call before_replace trigger even if space has no indexes Vladimir Davydov
2018-07-20 18:39 ` Konstantin Osipov
2018-07-21 12:26 ` Vladimir Davydov [this message]
2018-07-21 20:59 ` Konstantin Osipov
2018-07-23 10:15 ` Vladimir Davydov
2018-07-20 17:43 ` [PATCH 6/6] Introduce blackhole engine Vladimir Davydov
2018-07-20 18:42 ` Konstantin Osipov
2018-07-21 12:35 ` Vladimir Davydov
2018-07-23 11:02 ` Vladimir Davydov
2018-07-23 12:53 ` Vladimir Davydov
2018-07-23 18:30 ` [PATCH 0/6] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721122652.rll2tshmcsbhzsfn@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH 5/6] space: call before_replace trigger even if space has no indexes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox