From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] third_party: fix strings "true"/"false" in yaml
Date: Thu, 19 Jul 2018 15:11:31 +0300 [thread overview]
Message-ID: <20180719121131.3hmtn7b2qgpuy6ab@tkn_work_nb> (raw)
In-Reply-To: <20180719105434.gnmirhxsfxodmpg5@tarantool.org>
On Thu, Jul 19, 2018 at 01:54:34PM +0300, Kirill Yukhin wrote:
> Hello,
> On 12 июл 15:58, Kirill Shcherbatov wrote:
> > Strings containing "true" and "false" were converted
> > to a boolean type when serializing. Fixed.
> > Example:
> > type(yaml.decode(yaml.encode('false'))) == string
> > type(yaml.decode(yaml.encode('true'))) == string
> >
> > Closes #3476.
> > ---
> > https://github.com/tarantool/tarantool/compare/kshch/gh-3476-yaml-strings-with-true-and-false
> > https://github.com/tarantool/tarantool/issues/3476
> I've checked the patch into 1.10 branch.
>
> --
> Regards, Kirill Yukhin
>
Kirill,
Hm, it is bugfix and maybe we should update 1.9 too? Hovewer it is quite
small issue and of course I don't insist.
WBR, Alexander Turenko.
prev parent reply other threads:[~2018-07-19 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 12:58 [tarantool-patches] " Kirill Shcherbatov
2018-07-13 6:48 ` [tarantool-patches] " Kirill Yukhin
2018-07-19 10:54 ` Kirill Yukhin
2018-07-19 12:11 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719121131.3hmtn7b2qgpuy6ab@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] third_party: fix strings "true"/"false" in yaml' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox