From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Pettik <n.pettik@corp.mail.ru>
Cc: Nikita Tatunov <hollow653@gmail.com>, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: assertion fail on nested select
Date: Wed, 18 Jul 2018 19:51:49 +0300 [thread overview]
Message-ID: <20180718165149.kf5l67vvad3t3ysw@tkn_work_nb> (raw)
In-Reply-To: <CAEi+_aoR1Bq_V0=G0ediVrUk8Vcusjn4P+XwUWaYdGC-vHpMkQ@mail.gmail.com>
The patch LGTM. Nikita P., what do you think?
WBR, Alexander Turenko.
On Wed, Jul 18, 2018 at 06:37:00PM +0300, Nikita Tatunov wrote:
> I woudln't consider it as an actual 'fix' though.
>
> ср, 18 июл. 2018 г. в 18:17, [1]n.pettik@corp.mail.ru
> <[2]n.pettik@corp.mail.ru>:
>
> I tried to test that problem on this sqlite3 version with
> -DSQLITE_DEBUG and assertion fails there.
> Since flattening only makes another compound select-stmt with ORDER BY
> clause I guess error was
> occuring on flattened version of it. Moreover in latter versions of
> sqlite3 this assert was deleted and the
> restriction check wasn't fixed. So I assume sqlite3 developers just
> don't know about it or don't aim on
> fixing it as the error anyways occurs but on flattened subquery.
>
> Here is original fix of this assertion fail (JFYI):
> [3]https://www.sqlite.org/src/info/823779d31eb09cda
>
> References
>
> 1. mailto:n.pettik@corp.mail.ru
> 2. mailto:n.pettik@corp.mail.ru
> 3. https://www.sqlite.org/src/info/823779d31eb09cda
next prev parent reply other threads:[~2018-07-18 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 12:11 [tarantool-patches] " N.Tatunov
2018-07-17 13:59 ` [tarantool-patches] " Alexander Turenko
2018-07-18 12:34 ` Nikita Tatunov
2018-07-18 13:41 ` Nikita Tatunov
[not found] ` <07E4F387-E976-432B-A80B-E01B40BCF126@corp.mail.ru>
2018-07-18 15:37 ` Nikita Tatunov
2018-07-18 16:51 ` Alexander Turenko [this message]
2018-07-18 20:36 ` n.pettik
2018-07-19 12:47 ` Nikita Tatunov
2018-07-19 13:09 ` n.pettik
2018-07-19 15:22 ` Vladislav Shpilevoy
2018-07-20 13:21 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718165149.kf5l67vvad3t3ysw@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=hollow653@gmail.com \
--cc=n.pettik@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: assertion fail on nested select' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox