Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton
Date: Tue, 17 Jul 2018 17:22:34 +0300	[thread overview]
Message-ID: <20180717142234.c4kqjsllcfynx7aq@esperanza> (raw)
In-Reply-To: <1531836328.142893952@f406.i.mail.ru>

On Tue, Jul 17, 2018 at 05:05:28PM +0300, Olga Arkhangelskaia wrote:
> 
> 
> 
> >Вторник, 17 июля 2018, 16:13 +03:00 от Vladimir Davydov <vdavydov.dev@gmail.com>:
> >
> >As this is the second version of this patch, you should add v2 to the
> >subject line and write a brief change log. 
> Sorry, I remembered it after sending.
> >
> >
> >On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:
> >> Added test to check if the valid syslog configuration is ok.
> >> 
> >> Issue: #3502
> >
> >Should be:
> >
> >Closes #3502 
> Is ir because it is a bug? Because Kirill told me about Issue: and Branch: and then links.

Forget about everything Kirill told you ;-) Just use patches submitted
by other team members as sample (you should be subscribed to the mailing
list so you can see all of them).

We mention an issue in the commit message so that it is recognized by
GitHub. E.g. 'Closes ####' will make GitHub close the issue once the
commit is pushed to the trunk.

We also include hyperlinks to the issue and branch in the patch email.
These are for the reviewer. They are not committed to the git.


BTW I see that you use Mail.Ru web interface. Please don't - it mangles
code snippets. I strongly recommend you to install a mail user agent,
e.g. Thuderbird.

      reply	other threads:[~2018-07-17 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 10:25 Olga Arkhangelskaia
2018-07-17 10:25 ` [tarantool-patches] [PATCH 2/2] Fixes logging to syslog Olga Arkhangelskaia
2018-07-19 13:08   ` Vladimir Davydov
2018-07-17 13:13 ` [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Vladimir Davydov
2018-07-17 13:23   ` Vladimir Davydov
2018-07-17 14:07     ` Re[2]: " Olga Arkhangelskaia
2018-07-17 14:10       ` Vladimir Davydov
2018-07-17 14:05   ` Re[2]: " Olga Arkhangelskaia
2018-07-17 14:22     ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717142234.c4kqjsllcfynx7aq@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=arkholga@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox