From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton
Date: Tue, 17 Jul 2018 17:10:32 +0300 [thread overview]
Message-ID: <20180717141032.w2khpsek3n6z3s2g@esperanza> (raw)
In-Reply-To: <1531836452.68220112@f406.i.mail.ru>
[ Please add an extra new line after a quote when replying to an email -
this improves readability ]
On Tue, Jul 17, 2018 at 05:07:32PM +0300, Olga Arkhangelskaia wrote:
> >Hmm, the test doesn't pass on certain distros (see travis). I guess,
> >this is because they don't have syslog configured. What about wrapping
> >box.cfg in pcall and checking the status? Since we just want to check
> >that there's no crash, this should do.
> I'll do that way.
> >Or alternatively you can test
> >this by setting a custom syslog destination (you have to test it anyway
> >in your other patches AFAIR).
> Do you mean in syslog destination series?
Yes.
> I had a thought about it, but did not do in v2. Will keep in mind
Up to you.
next prev parent reply other threads:[~2018-07-17 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:25 Olga Arkhangelskaia
2018-07-17 10:25 ` [tarantool-patches] [PATCH 2/2] Fixes logging to syslog Olga Arkhangelskaia
2018-07-19 13:08 ` Vladimir Davydov
2018-07-17 13:13 ` [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Vladimir Davydov
2018-07-17 13:23 ` Vladimir Davydov
2018-07-17 14:07 ` Re[2]: " Olga Arkhangelskaia
2018-07-17 14:10 ` Vladimir Davydov [this message]
2018-07-17 14:05 ` Olga Arkhangelskaia
2018-07-17 14:22 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717141032.w2khpsek3n6z3s2g@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox