From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Olga Arkhangelskaia <arkholga@tarantool.org> Cc: tarantool-patches@freelists.org Subject: Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Date: Tue, 17 Jul 2018 16:23:23 +0300 [thread overview] Message-ID: <20180717132323.nfukmtsjzzshh3bt@esperanza> (raw) In-Reply-To: <20180717131349.wgidrqo6xml4i7cb@esperanza> On Tue, Jul 17, 2018 at 04:13:49PM +0300, Vladimir Davydov wrote: > > test/box-tap/cfg.test.lua | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > Please squash the test into the patch with the fix (`git rebase -i`) Hmm, the test doesn't pass on certain distros (see travis). I guess, this is because they don't have syslog configured. What about wrapping box.cfg in pcall and checking the status? Since we just want to check that there's no crash, this should do. Or alternatively you can test this by setting a custom syslog destination (you have to test it anyway in your other patches AFAIR). In this case, this particular fix doesn't need a test case at all - it's suffices to mention that the fix is going to be tested in the following patches. > > > > > diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua > > index ffafdbe42..605623013 100755 > > --- a/test/box-tap/cfg.test.lua > > +++ b/test/box-tap/cfg.test.lua > > @@ -6,7 +6,7 @@ local socket = require('socket') > > local fio = require('fio') > > local uuid = require('uuid') > > local msgpack = require('msgpack') > > -test:plan(95) > > +test:plan(96) > > > > -------------------------------------------------------------------------------- > > -- Invalid values > > @@ -464,5 +464,11 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new()) > > test:is(run_script(code), PANIC, "replicaset_uuid mismatch") > > fio.rmdir(dir) > > > > +-- > > +-- Check syslog configuration > > +-- > > +code = [[box.cfg{log = 'syslog:identity=tarantool'}]] > > +test:is(run_script(code), 0, "valid log configuration is broken") > > + > > test:check() > > os.exit(0)
next prev parent reply other threads:[~2018-07-17 13:23 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-17 10:25 Olga Arkhangelskaia 2018-07-17 10:25 ` [tarantool-patches] [PATCH 2/2] Fixes logging to syslog Olga Arkhangelskaia 2018-07-19 13:08 ` Vladimir Davydov 2018-07-17 13:13 ` [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Vladimir Davydov 2018-07-17 13:23 ` Vladimir Davydov [this message] 2018-07-17 14:07 ` Re[2]: " Olga Arkhangelskaia 2018-07-17 14:10 ` Vladimir Davydov 2018-07-17 14:05 ` Re[2]: " Olga Arkhangelskaia 2018-07-17 14:22 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180717132323.nfukmtsjzzshh3bt@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=arkholga@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox