Re: [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton

[Vladimir Davydov <vdavydov.dev@gmail.com>]

As this is the second version of this patch, you should add v2 to the
subject line and write a brief change log.

On Tue, Jul 17, 2018 at 01:25:07PM +0300, Olga Arkhangelskaia wrote:
> Added test to check if the valid syslog configuration is ok.
> 
> Issue: #3502

Should be:

Closes #3502

> ---
> https://github.com/tarantool/tarantool/issues/3502
> 
> Branch: OKriw/gh-3502-syslog-fix
> ---
> https://github.com/tarantool/tarantool/tree/OKriw/gh-3502-syslog-fix

You misunderstood me. The links shouldn't go to the commit message.
You should open the patch file produced by git-format-patch in your
favorite text editor and add the links manually after --- generated by
git-format-patch. Here's a couple of examples of what a patch email is
supposed to look like:

With a cover letter:
https://www.freelists.org/post/tarantool-patches/PATCH-v2-02-alter-fix-WAL-error-handling

Without a cover letter:
https://www.freelists.org/post/tarantool-patches/PATCH-v3-Introduce-replica-local-spaces

Note, neither links nor change log is included in the commit message
once a patch is committed:
https://github.com/tarantool/tarantool/commit/f64f46199e19542fa60eede939d62cd115abb83a

Please use them as sample.

> ---
>  test/box-tap/cfg.test.lua | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Please squash the test into the patch with the fix (`git rebase -i`)

> 
> diff --git a/test/box-tap/cfg.test.lua b/test/box-tap/cfg.test.lua
> index ffafdbe42..605623013 100755
> --- a/test/box-tap/cfg.test.lua
> +++ b/test/box-tap/cfg.test.lua
> @@ -6,7 +6,7 @@ local socket = require('socket')
>  local fio = require('fio')
>  local uuid = require('uuid')
>  local msgpack = require('msgpack')
> -test:plan(95)
> +test:plan(96)
>  
>  --------------------------------------------------------------------------------
>  -- Invalid values
> @@ -464,5 +464,11 @@ code = string.format(code_fmt, dir, instance_uuid, uuid.new())
>  test:is(run_script(code), PANIC, "replicaset_uuid mismatch")
>  fio.rmdir(dir)
>  
> +--
> +-- Check syslog configuration
> +--
> +code = [[box.cfg{log = 'syslog:identity=tarantool'}]]
> +test:is(run_script(code), 0, "valid log configuration is broken")
> +
>  test:check()
>  os.exit(0)