Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour of tonumber64
Date: Tue, 17 Jul 2018 14:27:46 +0300	[thread overview]
Message-ID: <20180717112746.mh2cqq22acw4mtsu@tkn_work_nb> (raw)
In-Reply-To: <8b7eb4a3-3aec-a63c-034e-fd0ace55d0d9@tarantool.org>

> > +-- gh-3466: Strange behaviour of tonumber64 function
> > +--
> > +tostring(tonumber64('18446744073709551615')) == '18446744073709551615ULL'
> > +tonumber64('18446744073709551616') == nil
> > +tostring(tonumber64('-9223372036854775808')) == '-9223372036854775808LL'
> 
> 2. Where is a test for another corner case? I mean INT64_MAX.
> 

I also propose to test zero.

WBR, Alexander Turenko.

  reply	other threads:[~2018-07-17 11:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 11:21 [tarantool-patches] " Kirill Shcherbatov
2018-07-16 10:23 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 12:49   ` Alexander Turenko
2018-07-16 13:15     ` Vladislav Shpilevoy
2018-07-16 13:42       ` Alexander Turenko
2018-07-16 13:55         ` Vladislav Shpilevoy
2018-07-16 14:09           ` Alexander Turenko
2018-07-16 16:52             ` Kirill Shcherbatov
2018-07-17  9:35               ` Vladislav Shpilevoy
2018-07-17 11:27                 ` Alexander Turenko [this message]
2018-07-17 12:03                   ` Kirill Shcherbatov
2018-07-17 21:48                     ` Vladislav Shpilevoy
2018-07-19 10:46 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717112746.mh2cqq22acw4mtsu@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour of tonumber64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox