From: Olga Arkhangelskaia <arkholga@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Olga Arkhangelskaia <arkholga@tarantool.org>
Subject: [tarantool-patches] [PATCH 2/2] Fixes logging to syslog
Date: Tue, 17 Jul 2018 13:25:08 +0300 [thread overview]
Message-ID: <20180717102508.87945-2-arkholga@tarantool.org> (raw)
In-Reply-To: <20180717102508.87945-1-arkholga@tarantool.org>
Mode logging to syslog was broken due to assertion in case
ov vaild configuration:
box.cfg{log = 'syslog:identity=tarantool'}
Isue: #3502
---
https://github.com/tarantool/tarantool/issues/3502
Branch: OKriw/gh-3502-syslog-fix
---
https://github.com/tarantool/tarantool/tree/OKriw/gh-3502-syslog-fix
---
src/box/box.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/box.cc b/src/box/box.cc
index 7c6312d78..9252e82c1 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -375,9 +375,9 @@ box_check_say()
tnt_raise(ClientError, ER_CFG, "log",
diag_last_error(diag_get())->errmsg);
}
+ diag_raise();
}
say_free_syslog_opts(&opts);
- diag_raise();
}
const char *log_format = cfg_gets("log_format");
--
2.14.3 (Apple Git-98)
next prev parent reply other threads:[~2018-07-17 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:25 [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Olga Arkhangelskaia
2018-07-17 10:25 ` Olga Arkhangelskaia [this message]
2018-07-19 13:08 ` [tarantool-patches] [PATCH 2/2] Fixes logging to syslog Vladimir Davydov
2018-07-17 13:13 ` [tarantool-patches] [PATCH 1/2] Test for valid syslog configuraton Vladimir Davydov
2018-07-17 13:23 ` Vladimir Davydov
2018-07-17 14:07 ` Re[2]: " Olga Arkhangelskaia
2018-07-17 14:10 ` Vladimir Davydov
2018-07-17 14:05 ` Re[2]: " Olga Arkhangelskaia
2018-07-17 14:22 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717102508.87945-2-arkholga@tarantool.org \
--to=arkholga@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH 2/2] Fixes logging to syslog' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox