From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Georgy Kirichenko <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] [PATCH] Do not recycle a fiber if it is canceled
Date: Mon, 16 Jul 2018 13:20:49 +0300 [thread overview]
Message-ID: <20180716102049.n5c4rrt33jpqmtye@esperanza> (raw)
In-Reply-To: <792cd653673e62d847222fb0ec53d8a6170aa8c9.1531481944.git.georgy@tarantool.org>
On Fri, Jul 13, 2018 at 02:47:41PM +0300, Georgy Kirichenko wrote:
> If a fiber pool reuses already canceled fiber then the fiber reports an
> error for any next request. Now canceled fiber returns and fiber pool
> creates a new one.
>
> Fixes #3527
> ---
> Issue: https://github.com/tarantool/tarantool/3527
> Branch:
> https://github.com/tarantool/tarantool/tree/gh-3527-fiber-is-cancelled-in-pool
>
>
> src/fiber_pool.c | 6 +++---
> test/app/fiber.result | 18 ++++++++++++++++++
> test/app/fiber.test.lua | 6 ++++++
> 3 files changed, 27 insertions(+), 3 deletions(-)
Looks good to me.
next prev parent reply other threads:[~2018-07-16 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 11:47 Georgy Kirichenko
2018-07-16 10:20 ` Vladimir Davydov [this message]
2018-07-16 14:57 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716102049.n5c4rrt33jpqmtye@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH] Do not recycle a fiber if it is canceled' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox