Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v6 2/2] replication: force gc to clean xdir on ENOSPC err
Date: Fri, 13 Jul 2018 11:48:57 +0300	[thread overview]
Message-ID: <20180713084857.dmr4sbqhmufj2fnz@tarantool.org> (raw)
In-Reply-To: <9baac2b91b8a687be7dfb3e7db4aea7bc86fcb33.1531406514.git.k.belyavskiy@tarantool.org>

Hello,
On 12 июл 17:44, Konstantin Belyavskiy wrote:
> Garbage collector do not delete xlog unless replica do not notify
> master with newer vclock. This can lead to running out of disk
> space error and this is not right behaviour since it will stop the
> master.
> Fix it by forcing gc to clean xlogs for replica with highest lag.
> Add an error injection and a test.
> 
> Changes in V2:
> - Promoting error from wal_thread to tx via cpipe.
> Changes in V3:
> - Delete consumers and only for replicas (but not backup).
> Changes in V4:
> - Bug fix and small changes according to review.
> Changes in V5:
> - Compare signatures of the oldest replica and the oldest snapshot
>   to keep to prevent deletion if it will not free any disk space.
> - Add say_crit on consumer deletion with a little information.
> Changes in V6:
> - Rebase to latest 1.10.
> - Update test.
Why did you put a ChangeLog entry to commit message?

--
Regards, Kirill Yukhin

      reply	other threads:[~2018-07-13  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 14:44 [tarantool-patches] [PATCH v6 0/2] force gc on running out of disk space Konstantin Belyavskiy
2018-07-12 14:44 ` [tarantool-patches] [PATCH v6 1/2] replication: rename thread from tx to tx_prio Konstantin Belyavskiy
2018-07-12 14:44 ` [tarantool-patches] [PATCH v6 2/2] replication: force gc to clean xdir on ENOSPC err Konstantin Belyavskiy
2018-07-13  8:48   ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713084857.dmr4sbqhmufj2fnz@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v6 2/2] replication: force gc to clean xdir on ENOSPC err' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox