Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 1/1] box: support reload whole module
Date: Wed, 11 Jul 2018 15:59:53 +0300	[thread overview]
Message-ID: <20180711125953.eevnmjygj2s7swwj@esperanza> (raw)
In-Reply-To: <e8c2eb9a-e3ff-7af8-3f8c-5bdc929be964@tarantool.org>

On Wed, Jul 11, 2018 at 03:52:46PM +0300, Kirill Shcherbatov wrote:
> On 11.07.2018 15:46, Vladimir Davydov wrote:
> > AFAIU a user may reload a whole module only if he has the global EXECUTE
> > privilege (because we don't have such an entity as module in our data
> > dictionary to grant access rights for). access_check_func(), which is
> > called by func_reload(), already checks the global EXECUTE privilege and
> > returns 0 (success) if it is set, no matter if the function was found or
> > not. So all you have to do is call module_reload() from func_reload() if
> > access_check_func() returned func = NULL, no?
> 
> No, this call iterates through all loaded functions of specified module and 
> reload all that belongs to initiator if any.

I understand what you code does, but I wonder why it does that.

  reply	other threads:[~2018-07-11 12:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 16:54 [tarantool-patches] " Kirill Shcherbatov
2018-07-09 18:06 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-10  6:49   ` Kirill Shcherbatov
2018-07-11  5:25     ` Georgy Kirichenko
2018-07-11 12:46     ` Vladimir Davydov
2018-07-11 12:52       ` Kirill Shcherbatov
2018-07-11 12:59         ` Vladimir Davydov [this message]
2018-07-11 14:50           ` Kirill Shcherbatov
2018-07-11 15:57       ` Vladimir Davydov
2018-07-12  8:27         ` Kirill Shcherbatov
2018-07-12  9:31           ` Vladimir Davydov
2018-07-13  6:16 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180711125953.eevnmjygj2s7swwj@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] Re: [PATCH v1 1/1] box: support reload whole module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox