Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Konstantin Belyavskiy <k.belyavskiy@tarantool.org>
Cc: tarantool-patches <tarantool-patches@freelists.org>
Subject: [tarantool-patches] Re: [PATCH v5 2/2] replication: force gc to clean xdir on ENOSPC err
Date: Tue, 10 Jul 2018 21:37:07 +0300	[thread overview]
Message-ID: <20180710183707.GE22105@chai> (raw)
In-Reply-To: <1531235432.907548046@f506.i.mail.ru>

* Konstantin Belyavskiy <k.belyavskiy@tarantool.org> [18/07/10 19:19]:
> Rebase to 1.10 - ok.
> 
> Using relay_stop() makes sense only with replica_on_relay_stop(), since
> relay_stop() itself actually do nothing with consumers.
> Regarding replica_on_relay_stop(), replica should be in "orphan" mode
> to avoid assertion in replica_delete(). And also there is a problem with
> monitoring, since replica will leave replication cluster and thus silent the error.
> 
> On other hand, in case of implementation based on removing consumer,
> replica, if being active again, will get an LSN gap and we will see an error.

This not a problem - it will rejoin once rejoin is in the trunk.
> 
> 1. Please give feedback on this section.
> 2. If not using relay_stop(), which branch use as a base 1.9 or 1.10?

1.10
> >Could you write a test with two 
> >"abandoned" replicas, each holding an xlog file? 
> Which xlog, the same one or different for each replicas?

Different one.

I know I skipped some questions - let's discuss the rest
separately, hope the above answers help.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2018-07-10 18:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 18:39 [tarantool-patches] [PATCH v5 0/2] force gc on running out of disk space Konstantin Belyavskiy
2018-07-05 18:39 ` [tarantool-patches] [PATCH v5 1/2] replication: rename thread from tx to tx_prio Konstantin Belyavskiy
2018-07-05 18:39 ` [tarantool-patches] [PATCH v5 2/2] replication: force gc to clean xdir on ENOSPC err Konstantin Belyavskiy
2018-07-06 17:00   ` [tarantool-patches] " Konstantin Osipov
2018-07-10 15:10     ` [tarantool-patches] " Konstantin Belyavskiy
2018-07-10 18:37       ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710183707.GE22105@chai \
    --to=kostja@tarantool.org \
    --cc=k.belyavskiy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v5 2/2] replication: force gc to clean xdir on ENOSPC err' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox