Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH] Fixes logging to syslog
@ 2018-07-10  8:11 Olga Arkhangelskaia
  2018-07-10 11:46 ` Vladimir Davydov
  2018-07-10 11:54 ` Vladimir Davydov
  0 siblings, 2 replies; 3+ messages in thread
From: Olga Arkhangelskaia @ 2018-07-10  8:11 UTC (permalink / raw)
  To: tarantool-patches; +Cc: Olga Arkhangelskaia

Fixes assertion when setting log to syslog
box.cfg{log = 'syslog:identity=tarantool'}

Closes #3502
---
 src/box/box.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/box/box.cc b/src/box/box.cc
index f00a4f32d..033829a7f 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -355,9 +355,9 @@ box_check_say()
 				tnt_raise(ClientError, ER_CFG, "log",
 					  diag_last_error(diag_get())->errmsg);
 			}
+			diag_raise();
 		}
 		say_free_syslog_opts(&opts);
-		diag_raise();
 	}
 
 	const char *log_format = cfg_gets("log_format");
-- 
2.14.3 (Apple Git-98)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [tarantool-patches] [PATCH] Fixes logging to syslog
  2018-07-10  8:11 [tarantool-patches] [PATCH] Fixes logging to syslog Olga Arkhangelskaia
@ 2018-07-10 11:46 ` Vladimir Davydov
  2018-07-10 11:54 ` Vladimir Davydov
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Davydov @ 2018-07-10 11:46 UTC (permalink / raw)
  To: Olga Arkhangelskaia; +Cc: tarantool-patches

On Tue, Jul 10, 2018 at 11:11:49AM +0300, Olga Arkhangelskaia wrote:
> Fixes assertion when setting log to syslog
> box.cfg{log = 'syslog:identity=tarantool'}
> 
> Closes #3502
> ---
>  src/box/box.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Test case is missing. Please add one to box-tap/cfg.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [tarantool-patches] [PATCH] Fixes logging to syslog
  2018-07-10  8:11 [tarantool-patches] [PATCH] Fixes logging to syslog Olga Arkhangelskaia
  2018-07-10 11:46 ` Vladimir Davydov
@ 2018-07-10 11:54 ` Vladimir Davydov
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Davydov @ 2018-07-10 11:54 UTC (permalink / raw)
  To: Olga Arkhangelskaia; +Cc: tarantool-patches

On Tue, Jul 10, 2018 at 11:11:49AM +0300, Olga Arkhangelskaia wrote:
> Fixes assertion when setting log to syslog
> box.cfg{log = 'syslog:identity=tarantool'}
> 
> Closes #3502
> ---
>  src/box/box.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Also, when submitting a patch, please put links to the branch and the
issue after '---' (or in the cover letter, if any), e.g.

  https://www.freelists.org/post/tarantool-patches/PATCH-v3-Introduce-replica-local-spaces

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-10 11:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-10  8:11 [tarantool-patches] [PATCH] Fixes logging to syslog Olga Arkhangelskaia
2018-07-10 11:46 ` Vladimir Davydov
2018-07-10 11:54 ` Vladimir Davydov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox