Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Tatunov <hollow653@gmail.com>
Cc: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: Remove 'BEGIN TRANSACTION'
Date: Mon, 9 Jul 2018 18:35:31 +0300	[thread overview]
Message-ID: <20180709153406.rhnb4wstnrwkphtk@tkn_work_nb> (raw)
In-Reply-To: <1530787337-18302-1-git-send-email-hollow653@gmail.com>

Hi Nikita!

I don't have objections against the patch, just two comments re tests.

It would be good to check a table content in the test to make sure a
transaction was executed as expected.

The new test failed in CI:

https://travis-ci.org/tarantool/tarantool/jobs/400390677
https://travis-ci.org/tarantool/tarantool/jobs/400390678

Please, ask next review from Nikita P.

WBR, Alexander Turenko.

On Thu, Jul 05, 2018 at 01:42:17PM +0300, N.Tatunov wrote:
> Patch is aimed on making our sql closer to ANSI sql.
> 
> With the patch applied only following commands can be used:
>  - "START TRANSACTION" to begin transaction.
>  - "COMMIT" to end transaction.
>  - "ROLLBACK" to rollback transaction without savepoints.
>  - "ROLLBACK TO .." to rollback transaction to savepoint.
> 
> Closes #2164
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/2164
> Branch: https://github.com/tarantool/tarantool/tree/N_Tatunov/gh-2164-remove-begin-transaction
> 

  parent reply	other threads:[~2018-07-09 15:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 10:42 [tarantool-patches] " N.Tatunov
2018-07-05 11:48 ` [tarantool-patches] " Nikita Tatunov
2018-07-09 15:35 ` Alexander Turenko [this message]
2018-07-13  2:15 ` n.pettik
2018-07-16 12:22   ` Nikita Tatunov
2018-07-19  0:24     ` n.pettik
2018-07-19 11:48       ` Nikita Tatunov
2018-07-19 14:03         ` n.pettik
2018-07-19 15:44           ` Vladislav Shpilevoy
2018-07-19 18:08             ` Nikita Tatunov
2018-07-19 18:13               ` Vladislav Shpilevoy
2018-07-20 13:24 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709153406.rhnb4wstnrwkphtk@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=hollow653@gmail.com \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: Remove '\''BEGIN TRANSACTION'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox