From: Konstantin Osipov <kostja@tarantool.org>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] Do not update schema_version on space:truncate().
Date: Fri, 6 Jul 2018 17:29:06 +0300 [thread overview]
Message-ID: <20180706142906.GA10648@chai> (raw)
In-Reply-To: <7de60a16-1273-6c1b-12d5-8e05ef1e3ff2@tarantool.org>
* Sergey Petrenko <sergepetrenko@tarantool.org> [18/07/06 17:27]:
> Will fix. I thought it'd be a good idea to only increment when we already
> know
> we won't be returning to the old state.
> So I should increase schema_version in UpdateSchemaVersion::alter() and
> decrease it in
> UpdateSchemaVersion::rollback() ?
Never decrement. Reloading a schema extra time won't break
anything.
And what about creation/drop of a space?
> Move
> schema_version increment to on_replace_dd_space()
OK.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-07-06 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 11:46 [tarantool-patches] " Serge Petrenko
2018-07-06 14:07 ` [tarantool-patches] " Konstantin Osipov
2018-07-06 14:24 ` Sergey Petrenko
2018-07-06 14:29 ` Konstantin Osipov [this message]
2018-07-06 15:15 ` Sergey Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706142906.GA10648@chai \
--to=kostja@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] Do not update schema_version on space:truncate().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox